Skip to content

Add real-world Kiro repos to test suite - #609

Merged
avifenesh merged 1 commit into
mainfrom
feature/add-real-world-kiro-repos-to-test-suite-598
Mar 2, 2026
Merged

Add real-world Kiro repos to test suite#609
avifenesh merged 1 commit into
mainfrom
feature/add-real-world-kiro-repos-to-test-suite-598

Conversation

@avifenesh

Copy link
Copy Markdown
Collaborator

Summary

  • add explicit Kiro-tagged real-world repos to tests/real-world/repos.yaml and replace stale unavailable entry
  • tighten kiro_ci_gate real-world coverage test to require a 4-repo Kiro baseline and verify required URLs with normalization
  • update changelog with Add real-world Kiro repos to test suite #598 Kiro real-world coverage expansion

Validation

  • cargo fmt --all
  • cargo fmt --check --all
  • cargo build -p agnix-cli
  • cargo test -p agnix-cli --test kiro_ci_gate -- --include-ignored
  • python3 scripts/real-world-validate.py --repos-file tests/real-world/repos.yaml --agnix-bin target/debug/agnix --category kiro --parallel 2 --timeout 120 --status pending --limit 4

Copilot AI review requested due to automatic review settings March 2, 2026 12:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands the real-world Kiro coverage set and tightens the CI gate to ensure a stable baseline of explicitly tagged Kiro repositories in the real-world manifest.

Changes:

  • Replaces the previous single Kiro entry with a curated set of 4 explicit kiro-categorized repos in tests/real-world/repos.yaml.
  • Strengthens kiro_ci_gate to require at least the 4-repo baseline and to verify required URLs via normalization.
  • Updates the changelog entry for issue #598.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/real-world/repos.yaml Adds/updates explicit Kiro-tagged repos used for real-world validation.
crates/agnix-cli/tests/kiro_ci_gate.rs Tightens CI gate assertions for Kiro real-world baseline and adds URL normalization.
CHANGELOG.md Documents the expanded Kiro real-world coverage baseline (#598).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 263 to 269
@@ -237,4 +268,24 @@ fn real_world_manifest_has_explicit_kiro_coverage() {
.all(|repo| repo_url_re.is_match(&repo.url)),
"All explicit 'kiro' category entries must be valid GitHub owner/repo URLs"

Copilot AI Mar 2, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repo_url_re currently allows ? / # (and other non-path characters) inside the owner/repo segments because it uses [^/]+. That means URLs like https://github.com/owner/repo?tab=readme would be treated as valid and could slip into the explicit Kiro baseline. Consider tightening validation (and/or normalize_repo_url) to reject query/fragment parts and ensure each segment is strictly an owner/repo name (e.g., disallow ?, #, and .git).

Copilot uses AI. Check for mistakes.
@avifenesh

Copy link
Copy Markdown
Collaborator Author

Reviewed Copilot summary comment for PR #609. No actionable code-change requests were raised, and CI + Kiro gate checks are green on current head.

@avifenesh
avifenesh merged commit e30002c into main Mar 2, 2026
12 checks passed
@avifenesh
avifenesh deleted the feature/add-real-world-kiro-repos-to-test-suite-598 branch March 2, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants