Add real-world Kiro repos to test suite - #609
Conversation
There was a problem hiding this comment.
Pull request overview
Expands the real-world Kiro coverage set and tightens the CI gate to ensure a stable baseline of explicitly tagged Kiro repositories in the real-world manifest.
Changes:
- Replaces the previous single Kiro entry with a curated set of 4 explicit
kiro-categorized repos intests/real-world/repos.yaml. - Strengthens
kiro_ci_gateto require at least the 4-repo baseline and to verify required URLs via normalization. - Updates the changelog entry for issue #598.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/real-world/repos.yaml | Adds/updates explicit Kiro-tagged repos used for real-world validation. |
| crates/agnix-cli/tests/kiro_ci_gate.rs | Tightens CI gate assertions for Kiro real-world baseline and adds URL normalization. |
| CHANGELOG.md | Documents the expanded Kiro real-world coverage baseline (#598). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -237,4 +268,24 @@ fn real_world_manifest_has_explicit_kiro_coverage() { | |||
| .all(|repo| repo_url_re.is_match(&repo.url)), | |||
| "All explicit 'kiro' category entries must be valid GitHub owner/repo URLs" | |||
There was a problem hiding this comment.
repo_url_re currently allows ? / # (and other non-path characters) inside the owner/repo segments because it uses [^/]+. That means URLs like https://github.com/owner/repo?tab=readme would be treated as valid and could slip into the explicit Kiro baseline. Consider tightening validation (and/or normalize_repo_url) to reject query/fragment parts and ensure each segment is strictly an owner/repo name (e.g., disallow ?, #, and .git).
|
Reviewed Copilot summary comment for PR #609. No actionable code-change requests were raised, and CI + Kiro gate checks are green on current head. |
Summary
tests/real-world/repos.yamland replace stale unavailable entrykiro_ci_gatereal-world coverage test to require a 4-repo Kiro baseline and verify required URLs with normalizationValidation