fix(sonar): S5886 explicit Profile construction; S5778 single-call raises block

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TJc5yvfweHP2AEccKNeaVd

Author: OriNachum

lobes/profiles/loader.py

@@ -79,7 +79,13 @@ def _apply_machine_registry(profile: Profile) -> Profile:
             continue
         overrides = {knob_name: knob.value for knob_name, knob in knobs.items()}
         updated_roles[role] = replace(updated_roles[role], **overrides)
-    return replace(profile, roles=MappingProxyType(updated_roles))
+    # Construct the Profile directly (rather than dataclasses.replace(profile,
+    # ...)) so the declared return type matches what a static checker infers —
+    # replace()'s generic signature resolves to the base DataclassInstance
+    # protocol for some checkers, not the concrete Profile subtype.
+    return Profile(
+        name=profile.name, summary=profile.summary, roles=MappingProxyType(updated_roles)
+    )
 
 
 def builtin_names() -> tuple[str, ...]:

tests/test_machines.py

@@ -157,8 +157,9 @@ def test_render_is_json_friendly_with_provenance() -> None:
 
 
 def test_duplicate_registration_rejected_without_replace() -> None:
+    spark = machines.get("spark")
     with pytest.raises(ValueError):
-        machines.register(machines.get("spark"))
+        machines.register(spark)
 
 
 # --- criterion 1: one file + one line, zero edits elsewhere ---------------