Apply feedback

Author: ajimenez1503

src/agentevals/api/app.py

@@ -33,7 +33,7 @@
     pass
 
 
-def _build_lifespan(*, manage_trace_manager_lifecycle: bool):
+def _build_lifespan():
     @asynccontextmanager
     async def lifespan(app: FastAPI):
         log_level_str = os.getenv("AGENTEVALS_LOG_LEVEL", "INFO").upper()
@@ -49,10 +49,10 @@ async def lifespan(app: FastAPI):
             log_buffer.setFormatter(logging.Formatter("%(levelname)s:%(name)s:%(message)s"))
             ae_logger.addHandler(log_buffer)
         mgr = getattr(app.state, "trace_manager", None)
-        if manage_trace_manager_lifecycle and mgr:
+        if mgr:
             mgr.start_cleanup_task()
         yield
-        if manage_trace_manager_lifecycle and mgr:
+        if mgr:
             await mgr.shutdown()
         ae_logger.removeHandler(log_buffer)
 
@@ -63,14 +63,13 @@ def create_app(
     *,
     trace_manager: StreamingTraceManager | None = None,
     enable_streaming: bool = False,
-    manage_trace_manager_lifecycle: bool = True,
 ) -> FastAPI:
     """Create the main agentevals API app."""
     app = FastAPI(
         title="agentevals API",
         version=__version__,
         description="REST API for evaluating agent traces using ADK's scoring framework",
-        lifespan=_build_lifespan(manage_trace_manager_lifecycle=manage_trace_manager_lifecycle),
+        lifespan=_build_lifespan(),
     )
 
     app.add_middleware(

src/agentevals/cli.py

@@ -534,8 +534,6 @@ async def _run_servers(
     otlp_grpc_port: int,
     *,
     mcp_port: int | None = None,
-    reload: bool = False,
-    reload_dirs: list[str] | None = None,
     log_level: str = "warning",
 ) -> None:
     """Start API, OTLP HTTP+gRPC receivers, and optional MCP (Streamable HTTP)."""
@@ -547,11 +545,8 @@ async def _run_servers(
 
     shared_kwargs: dict = {
         "host": host,
-        "reload": reload,
         "log_level": log_level,
     }
-    if reload_dirs:
-        shared_kwargs["reload_dirs"] = reload_dirs
 
     mgr = StreamingTraceManager()
     main_app = create_app(trace_manager=mgr, enable_streaming=True)
@@ -703,17 +698,13 @@ def serve(
         click.echo("Waiting for agent connections...")
         click.echo()
 
-        src_path = Path(__file__).parent.parent
-        reload_dirs = [str(src_path)]
         asyncio.run(
             _run_servers(
                 host,
                 port,
                 otlp_http_port,
                 otlp_grpc_port,
                 mcp_port=mcp_port,
-                reload=True,
-                reload_dirs=reload_dirs,
                 log_level="info",
             )
         )

tests/test_cli.py

@@ -73,6 +73,10 @@ def fake_server_factory(config):
     assert captured["port"] == 4317
     assert main_app.state.trace_manager is manager
     assert otlp_app.state.trace_manager is manager
+    assert "reload" not in created_servers[0].config.kwargs
+    assert "reload_dirs" not in created_servers[0].config.kwargs
+    assert "reload" not in created_servers[1].config.kwargs
+    assert "reload_dirs" not in created_servers[1].config.kwargs
     assert fake_grpc_server.started is True
     assert created_servers[0].handle_exit is not None
     assert created_servers[1].handle_exit is not None