address review feedback

Author: krisztianfekete

src/agentevals/loader/auto.py

@@ -40,19 +40,20 @@ def detect_format(path: str) -> str | None:
     """Return the format name for ``path`` (``"jaeger-json"`` or ``"otlp-json"``).
 
     Order:
-    1. ``.jsonl`` extension implies OTLP (one span per line).
-    2. Otherwise read and inspect top-level keys:
+    1. The file must exist and be readable. Missing/unreadable files always
+       return ``None`` regardless of extension.
+    2. ``.jsonl`` extension implies OTLP (one span per line).
+    3. Otherwise read and inspect top-level keys:
        - ``resourceSpans`` / ``batches`` / wrapped ``trace.{...}``  → OTLP
        - ``data``                                                    → Jaeger
-    Returns ``None`` if the file isn't valid JSON or the shape isn't
-    recognized; callers that still want to attempt a load can fall back
-    to a default.
+    Returns ``None`` when the file is missing, unreadable, not valid JSON,
+    or the shape isn't recognized; callers that still want to attempt a
+    load can fall back to a default.
     """
-    if path.lower().endswith(".jsonl"):
-        return OTLP_JSON
-
     try:
         with open(path) as f:
+            if path.lower().endswith(".jsonl"):
+                return OTLP_JSON
             data = json.load(f)
     except (OSError, json.JSONDecodeError):
         return None

tests/test_loader_auto.py

@@ -148,6 +148,12 @@ def test_invalid_json_returns_none(self):
     def test_missing_file_returns_none(self):
         assert detect_format("/nonexistent/path/that/should/not/exist.json") is None
 
+    def test_missing_jsonl_file_returns_none(self):
+        # The ``.jsonl`` shortcut must not bypass the existence check;
+        # otherwise a missing file would lie about its format and confuse
+        # downstream loaders with a worse error message.
+        assert detect_format("/nonexistent/path/that/should/not/exist.jsonl") is None
+
     def test_unrecognized_shape_returns_none(self):
         path = _write_tmp(json.dumps({"foo": "bar"}))
         try:

ui/src/lib/trace-loader.ts

@@ -47,13 +47,24 @@ interface OtlpAttribute {
   };
 }
 
+// OTLP/JSON encodes int64 values as strings to preserve precision past
+// Number.MAX_SAFE_INTEGER (2^53 - 1). Convert only when the value still
+// fits a JavaScript safe integer; otherwise keep the original string so
+// large IDs/counters/timestamps round-trip without silent corruption.
+function parseOtlpIntValue(value: number | string): number | string {
+  if (typeof value === 'number') return value;
+  if (!/^-?\d+$/.test(value)) return value;
+  const parsed = Number(value);
+  return Number.isSafeInteger(parsed) ? parsed : value;
+}
+
 function extractOtlpAttributes(attrs: OtlpAttribute[] | undefined): Record<string, any> {
   const tags: Record<string, any> = {};
   for (const attr of attrs || []) {
     const v = attr.value;
     if (!v) continue;
     if (v.stringValue !== undefined) tags[attr.key] = v.stringValue;
-    else if (v.intValue !== undefined) tags[attr.key] = typeof v.intValue === 'string' ? parseInt(v.intValue) : v.intValue;
+    else if (v.intValue !== undefined) tags[attr.key] = parseOtlpIntValue(v.intValue);
     else if (v.doubleValue !== undefined) tags[attr.key] = v.doubleValue;
     else if (v.boolValue !== undefined) tags[attr.key] = v.boolValue;
   }