address review comments

Author: krisztianfekete

src/agentevals/api/streaming_routes.py

@@ -280,9 +280,9 @@ async def prepare_evaluation(request: PrepareEvaluationRequest):
             })
 
         return StandardResponse(data=PrepareEvaluationData(
-            eval_set_url=f"http://localhost:8001/api/streaming/download/{os.path.basename(eval_set_file)}",
+            eval_set_url=f"/api/streaming/download/{os.path.basename(eval_set_file)}",
             trace_urls=[
-                f"http://localhost:8001/api/streaming/download/{os.path.basename(tf['file_path'])}"
+                f"/api/streaming/download/{os.path.basename(tf['file_path'])}"
                 for tf in trace_files
             ],
             num_traces=len(trace_files),

ui/src/api/client.ts

@@ -1,4 +1,4 @@
-import type { RunResult, EvalConfig, TraceResult, StandardResponse } from '../lib/types';
+import type { RunResult, EvalConfig, TraceResult, MetricMetadata, StandardResponse } from '../lib/types';
 import { config } from '../config';
 
 const API_BASE_URL = `${config.api.baseUrl}/api`;
@@ -150,22 +150,22 @@ export async function evaluateTracesStreaming(
   }
 }
 
-export async function listMetrics() {
+export async function listMetrics(): Promise<MetricMetadata[]> {
   try {
     const response = await fetch(`${API_BASE_URL}/metrics`);
 
     if (!response.ok) {
       throw new Error(`Failed to fetch metrics: ${response.statusText}`);
     }
 
-    return unwrap(response);
+    return unwrap<MetricMetadata[]>(response);
   } catch (error) {
     console.error('Failed to list metrics:', error);
     throw error;
   }
 }
 
-export async function validateEvalSet(evalSetFile: File) {
+export async function validateEvalSet(evalSetFile: File): Promise<{ valid: boolean; evalSetId?: string; numCases?: number; errors?: string[] }> {
   const formData = new FormData();
   formData.append('eval_set_file', evalSetFile);
 
@@ -179,7 +179,7 @@ export async function validateEvalSet(evalSetFile: File) {
       throw new Error(`Failed to validate eval set: ${response.statusText}`);
     }
 
-    return unwrap(response);
+    return unwrap<{ valid: boolean; evalSetId?: string; numCases?: number; errors?: string[] }>(response);
   } catch (error) {
     console.error('Failed to validate eval set:', error);
     throw error;
@@ -247,18 +247,18 @@ export async function loadBugReport(
     throw new Error(errorMessage);
   }
 
-  return unwrap(response);
+  return unwrap<{ loadedSessions: string[]; count: number }>(response);
 }
 
-export async function healthCheck() {
+export async function healthCheck(): Promise<{ status: string; version: string }> {
   try {
     const response = await fetch(`${API_BASE_URL}/health`);
 
     if (!response.ok) {
       throw new Error(`Health check failed: ${response.statusText}`);
     }
 
-    return unwrap(response);
+    return unwrap<{ status: string; version: string }>(response);
   } catch (error) {
     console.error('Health check failed:', error);
     throw error;