chore(effect-cleanup): fix replay stub + dedupe unbound errors

- server-effect: replace throwing replay() stub in
  unconfiguredEventLogLayer with Stream.fail(...).pipe(Stream.orDie) so
  the failure surfaces through the Stream channel like the real ops,
  and extract the repeated "not provided" message to a constant.
- client-effect: dedupe the inline TaggedTransportError construction
  for submit/cancel via a shared UNBOUND_MESSAGE + unboundError() helper.
- runtime tests: replace `_tag === "Some"` discriminator checks with
  Option.isSome (plus an explicit assertion so a None failure can't
  silently skip the inner expect), and the runHead Option result with
  Option.isNone narrowing in server-effect.test.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: Nick Ficano

packages/client/src/client-effect.ts

@@ -99,26 +99,19 @@ export interface ARCPClientServiceShape {
 // `ARCPClient | null`). Without the explicit annotation Effect.Service infers
 // `client: null` and `ARCPClientService.make({ client })` rejects a non-null
 // client.
+const UNBOUND_MESSAGE =
+  "ARCPClientService is not bound; use ARCPClientLayer or makeARCPClientRuntime";
+
+const unboundError = (): TaggedTransportError =>
+  new TaggedTransportError({
+    cause: new Error(UNBOUND_MESSAGE),
+    kind: "send",
+  });
+
 const UNBOUND: ARCPClientServiceShape = {
   client: null,
-  submit: () =>
-    Effect.fail(
-      new TaggedTransportError({
-        cause: new Error(
-          "ARCPClientService is not bound; use ARCPClientLayer or makeARCPClientRuntime",
-        ),
-        kind: "send",
-      }),
-    ),
-  cancel: () =>
-    Effect.fail(
-      new TaggedTransportError({
-        cause: new Error(
-          "ARCPClientService is not bound; use ARCPClientLayer or makeARCPClientRuntime",
-        ),
-        kind: "send",
-      }),
-    ),
+  submit: () => Effect.fail(unboundError()),
+  cancel: () => Effect.fail(unboundError()),
   close: Effect.void,
 };
 

packages/runtime/src/server-effect.ts

@@ -144,25 +144,21 @@ function eventLogServiceLayer(
   return opts.eventLogLayer ?? unconfiguredEventLogLayer();
 }
 
+const UNCONFIGURED_EVENT_LOG = "EventLogService not provided to ARCPRuntimeLayer";
+
 function unconfiguredEventLogLayer(): Layer.Layer<EventLogService> {
   // The default-provided ops on `EventLogService` already fail-fast on every
   // method. We re-wrap them as an explicit layer here so the runtime layer
   // composition has a concrete `Layer<EventLogService>` to merge.
   const unconfigured: EventLogEffect = {
-    append: () => Effect.die("EventLogService not provided to ARCPRuntimeLayer"),
-    appendBatch: () =>
-      Effect.die("EventLogService not provided to ARCPRuntimeLayer"),
-    replay: () => {
-      throw new Error("EventLogService not provided to ARCPRuntimeLayer");
-    },
-    readSince: () =>
-      Effect.die("EventLogService not provided to ARCPRuntimeLayer"),
-    readSinceSeq: () =>
-      Effect.die("EventLogService not provided to ARCPRuntimeLayer"),
-    count: () => Effect.die("EventLogService not provided to ARCPRuntimeLayer"),
-    getById: () =>
-      Effect.die("EventLogService not provided to ARCPRuntimeLayer"),
-    query: () => Effect.die("EventLogService not provided to ARCPRuntimeLayer"),
+    append: () => Effect.die(UNCONFIGURED_EVENT_LOG),
+    appendBatch: () => Effect.die(UNCONFIGURED_EVENT_LOG),
+    replay: () => Stream.fail(UNCONFIGURED_EVENT_LOG).pipe(Stream.orDie),
+    readSince: () => Effect.die(UNCONFIGURED_EVENT_LOG),
+    readSinceSeq: () => Effect.die(UNCONFIGURED_EVENT_LOG),
+    count: () => Effect.die(UNCONFIGURED_EVENT_LOG),
+    getById: () => Effect.die(UNCONFIGURED_EVENT_LOG),
+    query: () => Effect.die(UNCONFIGURED_EVENT_LOG),
   };
   return Layer.succeed(EventLogService, EventLogService.make(unconfigured));
 }

packages/runtime/test/job-effect.test.ts

@@ -6,7 +6,7 @@ import type {
   JobResultPayload,
   JobStateName,
 } from "@arcp/core/messages";
-import { Cause, Effect, Exit, Fiber } from "effect";
+import { Cause, Effect, Exit, Fiber, Option } from "effect";
 import { describe, expect, it } from "vitest";
 
 import {
@@ -135,7 +135,8 @@ describe("JobService (Effect)", () => {
     expect(Exit.isFailure(exit)).toBe(true);
     if (Exit.isFailure(exit)) {
       const failure = Cause.failureOption(exit.cause);
-      if (failure._tag === "Some") {
+      expect(Option.isSome(failure)).toBe(true);
+      if (Option.isSome(failure)) {
         expect(failure.value).toBeInstanceOf(TaggedInvalidRequest);
       }
     }
@@ -238,8 +239,8 @@ describe("watchdogEffect (Effect)", () => {
     expect(Exit.isFailure(exit)).toBe(true);
     if (Exit.isFailure(exit)) {
       const failure = Cause.failureOption(exit.cause);
-      expect(failure._tag).toBe("Some");
-      if (failure._tag === "Some") {
+      expect(Option.isSome(failure)).toBe(true);
+      if (Option.isSome(failure)) {
         expect(failure.value).toBeInstanceOf(TaggedHeartbeatLost);
       }
     }

packages/runtime/test/lease-effect.test.ts

@@ -1,6 +1,6 @@
 import { TaggedInvalidRequest, TaggedPermissionDenied } from "@arcp/core";
 import type { Lease } from "@arcp/core/messages";
-import { Cause, Effect, Exit } from "effect";
+import { Cause, Effect, Exit, Option } from "effect";
 import { describe, expect, it } from "vitest";
 
 import {
@@ -34,8 +34,8 @@ describe("validateLeaseOpEffect", () => {
     expect(Exit.isFailure(exit)).toBe(true);
     if (Exit.isFailure(exit)) {
       const failure = Cause.failureOption(exit.cause);
-      expect(failure._tag).toBe("Some");
-      if (failure._tag === "Some") {
+      expect(Option.isSome(failure)).toBe(true);
+      if (Option.isSome(failure)) {
         expect(failure.value).toBeInstanceOf(TaggedPermissionDenied);
       }
     }
@@ -84,7 +84,8 @@ describe("validateLeaseConstraintsEffect", () => {
     expect(Exit.isFailure(exit)).toBe(true);
     if (Exit.isFailure(exit)) {
       const failure = Cause.failureOption(exit.cause);
-      if (failure._tag === "Some") {
+      expect(Option.isSome(failure)).toBe(true);
+      if (Option.isSome(failure)) {
         expect(failure.value).toBeInstanceOf(TaggedInvalidRequest);
       }
     }

packages/runtime/test/server-effect.test.ts

@@ -4,7 +4,7 @@ import {
   silentLogger,
   type TransportEffect,
 } from "@arcp/core";
-import { Effect, Fiber, Stream } from "effect";
+import { Effect, Fiber, Option, Stream } from "effect";
 import { describe, expect, it, vi } from "vitest";
 
 import { AgentRegistryService } from "../src/agent-registry.js";
@@ -197,14 +197,8 @@ async function collectFirstFrame(
   );
   const result = await Effect.runPromise(program);
   // `runHead` resolves to an Option; an empty stream is a test failure.
-  const opt = result as { _tag: "Some" | "None"; value?: Record<string, unknown> };
-  if (opt._tag === "None") {
+  if (Option.isNone(result)) {
     throw new Error(`stream ended without a "${type}" frame`);
   }
-  // value is guaranteed defined when _tag is Some — narrow defensively.
-  const frame = opt.value;
-  if (frame === undefined) {
-    throw new Error(`stream resolved Some without a frame value`);
-  }
-  return frame;
+  return result.value;
 }

packages/runtime/test/session-effect.test.ts

@@ -3,7 +3,7 @@ import { TaggedUnauthenticated } from "@arcp/core";
 import type { BaseEnvelope } from "@arcp/core/envelope";
 import { UnauthenticatedError } from "@arcp/core/errors";
 import type { JobErrorPayload } from "@arcp/core/messages";
-import { Cause, Effect, Exit } from "effect";
+import { Cause, Effect, Exit, Option } from "effect";
 import { describe, expect, it } from "vitest";
 
 import {
@@ -93,8 +93,8 @@ describe("SessionContextService (Effect)", () => {
     expect(Exit.isFailure(exit)).toBe(true);
     if (Exit.isFailure(exit)) {
       const failure = Cause.failureOption(exit.cause);
-      expect(failure._tag).toBe("Some");
-      if (failure._tag === "Some") {
+      expect(Option.isSome(failure)).toBe(true);
+      if (Option.isSome(failure)) {
         expect(failure.value).toBeInstanceOf(TaggedUnauthenticated);
       }
     }