fix bug

Author: Erica177

hiclaw-controller/internal/controller/manager_controller.go

@@ -345,10 +345,10 @@ func (r *ManagerReconciler) failManagerUpdate(ctx context.Context, m *v1beta1.Ma
 // --- Desired state reconciliation ---
 
 func (r *ManagerReconciler) reconcileDesiredState(ctx context.Context, m *v1beta1.Manager, desired string) (reconcile.Result, error) {
-	// If current phase already matches desired state, verify the pod still exists.
-	if m.Status.Phase == desired && desired == "Running" {
-		return r.ensureManagerPodExists(ctx, m)
-	}
+	// If current phase already matches desired state, nothing to do.
+	// This also avoids calling backend Status/Stop/Delete for Managers
+	// in Docker mode, where the container name ("hiclaw-manager") doesn't
+	// include the backend's worker prefix ("hiclaw-worker-").
 	if m.Status.Phase == desired {
 		return reconcile.Result{}, nil
 	}
@@ -547,28 +547,6 @@ func (r *ManagerReconciler) failManagerLifecycle(ctx context.Context, m *v1beta1
 	return reconcile.Result{RequeueAfter: time.Minute}, fmt.Errorf("%s", msg)
 }
 
-// ensureManagerPodExists checks if the manager's pod/container still exists.
-func (r *ManagerReconciler) ensureManagerPodExists(ctx context.Context, m *v1beta1.Manager) (reconcile.Result, error) {
-	wb := r.managerBackend(ctx)
-	if wb == nil {
-		return reconcile.Result{}, nil
-	}
-
-	containerName := managerContainerName(m.Name)
-	result, err := wb.Status(ctx, containerName)
-	if err != nil {
-		return reconcile.Result{RequeueAfter: reconcileRetryDelay}, nil
-	}
-
-	if result.Status == backend.StatusRunning || result.Status == backend.StatusStarting {
-		return reconcile.Result{}, nil
-	}
-
-	logger := log.FromContext(ctx)
-	logger.Info("pod missing for Running manager, recreating", "name", m.Name, "backendStatus", result.Status)
-	return r.ensureManagerRunning(ctx, m)
-}
-
 func (r *ManagerReconciler) SetupWithManager(mgr ctrl.Manager) error {
 	builder := ctrl.NewControllerManagedBy(mgr).
 		For(&v1beta1.Manager{})

hiclaw-controller/internal/controller/worker_controller.go

@@ -400,12 +400,8 @@ func (r *WorkerReconciler) failUpdate(ctx context.Context, w *v1beta1.Worker, ms
 // reconcileDesiredState compares the desired lifecycle state (spec.state) with
 // the actual backend state and takes corrective action when drift is detected.
 func (r *WorkerReconciler) reconcileDesiredState(ctx context.Context, w *v1beta1.Worker, desired string) (reconcile.Result, error) {
-	// If current phase already matches desired state, verify the pod still exists.
-	// The pod may have been deleted externally (e.g. kubectl delete pod) while
-	// the CR status still shows Running.
-	if w.Status.Phase == desired && desired == "Running" {
-		return r.ensurePodExists(ctx, w)
-	}
+	// If current phase already matches desired state, nothing to do.
+	// This also avoids unnecessary backend Status calls on every reconcile.
 	if w.Status.Phase == desired {
 		return reconcile.Result{}, nil
 	}
@@ -575,34 +571,6 @@ func (r *WorkerReconciler) failLifecycle(ctx context.Context, w *v1beta1.Worker,
 	return reconcile.Result{RequeueAfter: time.Minute}, fmt.Errorf("%s", msg)
 }
 
-// ensurePodExists checks if the worker's pod/container still exists.
-// If the pod was deleted externally while the CR status is Running,
-// this triggers recreation via ensureWorkerRunning.
-func (r *WorkerReconciler) ensurePodExists(ctx context.Context, w *v1beta1.Worker) (reconcile.Result, error) {
-	if r.Backend == nil {
-		return reconcile.Result{}, nil
-	}
-	wb := r.Backend.DetectWorkerBackend(ctx)
-	if wb == nil {
-		return reconcile.Result{}, nil
-	}
-
-	result, err := wb.Status(ctx, w.Name)
-	if err != nil {
-		// Backend error — don't panic, just requeue
-		return reconcile.Result{RequeueAfter: reconcileRetryDelay}, nil
-	}
-
-	if result.Status == backend.StatusRunning || result.Status == backend.StatusStarting {
-		return reconcile.Result{}, nil // pod exists, all good
-	}
-
-	// Pod is gone — trigger recreation
-	logger := log.FromContext(ctx)
-	logger.Info("pod missing for Running worker, recreating", "name", w.Name, "backendStatus", result.Status)
-	return r.ensureWorkerRunning(ctx, w)
-}
-
 func (r *WorkerReconciler) SetupWithManager(mgr ctrl.Manager) error {
 	builder := ctrl.NewControllerManagedBy(mgr).
 		For(&v1beta1.Worker{})