Fix: make sure no invalid docker tags are applied through invalid or unavailable git branch names (#48)

* fix: check if branch name is empty before applying tag

* fix: transform branch name into valid docker tag before application

* fix: use 68337 to treat DOCKER_TAG as a local var

* fix: use 68337 to treat DOCKER_TAG as a local var

* fix: use builtin substitution for PROJECT_ID

Author: philippschroeppel

cloudbuild.yaml

@@ -15,10 +15,19 @@ steps:
       - "-c"
       - |
         # Prepare tag list
-        TAGS="-t us-docker.pkg.dev/$PROJECT_ID/nebulous/server:$SHORT_SHA -t us-docker.pkg.dev/$PROJECT_ID/nebulous/server:$BRANCH_NAME"
+        TAGS="-t us-docker.pkg.dev/$PROJECT_ID/nebulous/server:$SHORT_SHA"
+
+        # Add branch name tag if BRANCH_NAME is not empty
+        if [ -n "$BRANCH_NAME" ]; then
+          echo "Detected branch: $BRANCH_NAME. Adding branch tag."
+          DOCKER_TAG=$(echo "$BRANCH_NAME" | sed 's/[^a-z0-9._-]/-/g' | sed 's/^[.-]//' | sed 's/[.-]$//')
+          echo "Transformed branch $BRANCH_NAME to Docker tag: $$DOCKER_TAG"
+          TAGS="$$TAGS -t us-docker.pkg.dev/$PROJECT_ID/nebulous/server:$$DOCKER_TAG"
+        fi
         
         # Add latest tag if on main branch
         if [ "$BRANCH_NAME" == "main" ]; then
+          echo "Detected main branch. Adding latest tag."
           TAGS="$$TAGS -t us-docker.pkg.dev/$PROJECT_ID/nebulous/server:latest"
         fi