fix: copilot comments

Author: goran-ethernal

aggsender/query/ger_query.go

@@ -13,7 +13,8 @@ import (
 	"github.com/ethereum/go-ethereum/common"
 )
 
-var createAgglayerGERL1func = func(gerAddr common.Address, l1Client aggkittypes.BaseEthereumClienter) (types.AgglayerGER, error) {
+var createAgglayerGERL1func = func(gerAddr common.Address,
+	l1Client aggkittypes.BaseEthereumClienter) (types.AgglayerGER, error) {
 	return agglayerger.NewAgglayerger(gerAddr, l1Client)
 }
 
@@ -124,7 +125,7 @@ func NewL1GERDataQuerier(
 ) (types.L1GERQuerier, error) {
 	agglayerGER, err := createAgglayerGERL1func(l1AgglayerGERAddr, l1Client)
 	if err != nil {
-		return nil, fmt.Errorf("failed to initialize L1 GER manager contract: %v", err)
+		return nil, fmt.Errorf("failed to initialize L1 GER manager contract: %w", err)
 	}
 
 	return &l1GERDataQuerier{
@@ -136,7 +137,8 @@ func NewL1GERDataQuerier(
 
 // DoesGERExistOnContract checks if the given GER exists on the Agglayer GER contract
 func (g *l1GERDataQuerier) DoesGERExistOnContract(ctx context.Context, ger common.Hash) (bool, error) {
-	blockNum, err := g.blockFinality.BlockNumber(ctx, g.l1Client) // TODO - maybe get the header and use block hash instead?
+	// TODO - maybe get the header and use block hash instead?
+	blockNum, err := g.blockFinality.BlockNumber(ctx, g.l1Client)
 	if err != nil {
 		return false, fmt.Errorf("error getting block number for finality %s: %w", g.blockFinality.String(), err)
 	}

aggsender/validator/validate_certificate.go

@@ -16,6 +16,7 @@ import (
 var (
 	ErrNilCertificate        = errors.New("aggsender-validator nil certificate")
 	ErrMetadataNotCompatible = errors.New("aggsender-validator metadata not compatible with the current version")
+	errGERNotExists          = errors.New("GER does not exist on L1 GER contract")
 )
 
 // CertificateValidator is a object to validate a certificate
@@ -29,6 +30,20 @@ type CertificateValidator struct {
 	l1GERQuerier types.L1GERQuerier
 }
 
+// NewAggsenderValidator creates a new CertificateValidator instance with the provided dependencies.
+// It initializes the validator with a logger, verification flow, and various data queriers
+// needed for certificate validation operations.
+//
+// Parameters:
+//   - logger: Logger instance for recording validation operations and errors
+//   - flow: AggsenderVerifierFlow that defines the verification workflow
+//   - l1InfoTreeDataQuerier: Querier for L1 info tree data
+//   - certQuerier: Querier for certificate data
+//   - lerQuerier: Querier for LER (Local Exit Root) data
+//   - l1GERQuerier: Querier for L1 GER (Global Exit Root) data
+//
+// Returns:
+//   - *CertificateValidator: A new validator instance ready for certificate validation
 func NewAggsenderValidator(logger aggkitcommon.Logger,
 	flow types.AggsenderVerifierFlow,
 	l1InfoTreeDataQuerier types.L1InfoTreeDataQuerier,
@@ -53,7 +68,7 @@ func (a *CertificateValidator) ValidateGER(ctx context.Context, ger common.Hash)
 	}
 
 	if !doesExist {
-		return fmt.Errorf("global exit root %s does not exist on L1 GER contract", ger.String())
+		return fmt.Errorf("%w: %s", errGERNotExists, ger.String())
 	}
 
 	return nil

aggsender/validator/validator_service.go

@@ -2,6 +2,7 @@ package validator
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	v1types "buf.build/gen/go/agglayer/interop/protocolbuffers/go/agglayer/interop/types/v1"
@@ -66,8 +67,8 @@ func (s *ValidatorService) ValidateGER(
 ) (*v1.ValidateGERResponse, error) {
 	if req == nil || req.Ger == nil {
 		return nil, grpc.GRPCError{
-			Code:    codes.NotFound,
-			Message: "required a GlobalExitRoot",
+			Code:    codes.InvalidArgument,
+			Message: "GlobalExitRoot is required",
 		}
 	}
 
@@ -76,10 +77,16 @@ func (s *ValidatorService) ValidateGER(
 
 	err := s.validator.ValidateGER(ctx, ger)
 	if err != nil {
-		s.log.Errorf("Error signing GER: %v", err)
+		s.log.Errorf("Error validating GER: %v", err)
+
+		code := codes.Internal
+		if errors.Is(err, errGERNotExists) {
+			code = codes.NotFound
+		}
+
 		return nil, grpc.GRPCError{
-			Code:    codes.Internal,
-			Message: "Error signing GER: " + err.Error(),
+			Code:    code,
+			Message: "Error validating GER: " + err.Error(),
 		}
 	}