Remediations SC v12 (agglayer v0.3.5) #206

[invocamanman]

External Audit SC v12 (aggLayer v0.3.5)

Comments

• All findings has been addressed in a separate issue and it has the same name as the finding in the report
  • all of them are placed in ready to review
  • Inside the issue there are comments and/or commits/PR where the finding has been addressed
• An additional pull request has been merged since the external audit began (apart from the remediation PRs)
  • Please refer to the PR list section
  • You will notice a minor renaming and reorganization of the smart contracts. We would like to ensure that no contract functionality has been impacted as a result of this renaming/restructuring. Please note that your remediation checks may take longer than expected due to these changes

Tags with remediations

https://github.com/agglayer/agglayer-contracts/releases/tag/v12.1.0-rc.4

Git Diff

v12.1.0-rc.3...v12.1.0-rc.4

Documentation

• Agglayer Protocol
  • Specifications new consensus type
    • Motivation and context
    • Formal specification
  • Outpost chains
• SC
  • v12
  • each SC has its own documentation

PR list

All PR on top of v12.1.0-rc.3 will be documented here in order to provide the external audit firm a diff of all the changes.

• feat: Finished upgrade contracts to v12 script #522
  • add upgrade script for v12 SCs
  • do not affect external-audit remediations
• Internal audit + initializaiton fixes #528
  • minor fixes internal audit
  • affects external-audit remediations
• fix: patch contracts verification script #531
  • upgrade verify-contracts script
  • do not affect external-audit remediations
• all global owners #529
  • global owners modification
  • do not affect external-audit remediations
• allow aggchainECDSAMultig with isVanillaClient = false. Add batchData… #532
  • fix create rollup script
  • do not affect external-audit remediations
• Feature/renaming agglayer #525
  • renaming SCs
  • affects external-audit remediations
• reorg v2 -> contracts #526
  • minor reorganization SC
  • affects external-audit remediations
• fix genesis bridgeLib + inconsistencies #536
  • fix script 1_createGenesis.ts
  • affects external-audit remediations
• Feature/fix migration #534
  • fix Zero handling LET for migrations
  • affects external-audit remediations
• several remediations #538
  • audit remediations internal/external
  • affects external-audit remediations
• Feature/audit remediations #537
  • audit remediations internal/external
  • affects external-audit remediations