Skip to content

Commit cd66341

Browse files
Omri Sarigagherzan
authored andcommitted
linux-firmware-rpidistro: Fix wireless error message on RPi
Fixes: #1396 Signed-off-by: Omri Sarig <omri.sarig@prevas.dk>
1 parent 9337582 commit cd66341

2 files changed

Lines changed: 80 additions & 0 deletions

File tree

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
1+
From 20741d848c32e0fb2e4841cf8bbc9ec3d198bb6b Mon Sep 17 00:00:00 2001
2+
From: Omri Sarig <omri.sarig@prevas.dk>
3+
Date: Thu, 9 Jan 2025 19:00:10 +0100
4+
Subject: [PATCH 2/2] Default all RPi 43455 boards to standard variant
5+
6+
As the patch above explains, the symlink that is being used by the
7+
brcmfmac43455-sdio.* files is one that is created by the Debian system,
8+
which we do not have in our implementation. Therefore, when the system
9+
tries to load these files, an error message is generated.
10+
11+
By changing the symlinks to be to the standard variant, the problem is
12+
solved for the build.
13+
14+
The code is also working without this patch - when the driver is unable
15+
to load the board-specific file (such as
16+
brcmfmac43455-sdio.raspberrypi,3-model-a-plus.bin), it reverts to using
17+
the base file (brcmfmac43455-sdio.bin), which is a correct link (as it
18+
is fixed in the patch above). However, the driver is still generating an
19+
error message in this case, which is being solved by linking the
20+
board-specific files to the standard variant as well.
21+
22+
Upstream-Status: Inappropriate [issue reported at https://github.com/RPi-Distro/firmware-nonfree/issues/26]
23+
Signed-off-by: Omri Sarig <omri.sarig@prevas.dk>
24+
---
25+
.../brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.bin | 2 +-
26+
.../brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.bin | 2 +-
27+
.../brcm/brcmfmac43455-sdio.raspberrypi,4-compute-module.bin | 2 +-
28+
.../brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.bin | 2 +-
29+
.../brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,5-model-b.bin | 2 +-
30+
5 files changed, 5 insertions(+), 5 deletions(-)
31+
32+
diff --git a/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.bin b/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.bin
33+
index 9c39208..b914838 120000
34+
--- a/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.bin
35+
+++ b/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,3-model-a-plus.bin
36+
@@ -1 +1 @@
37+
-../cypress/cyfmac43455-sdio.bin
38+
\ No newline at end of file
39+
+../cypress/cyfmac43455-sdio-standard.bin
40+
\ No newline at end of file
41+
diff --git a/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.bin b/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.bin
42+
index 9c39208..b914838 120000
43+
--- a/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.bin
44+
+++ b/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.bin
45+
@@ -1 +1 @@
46+
-../cypress/cyfmac43455-sdio.bin
47+
\ No newline at end of file
48+
+../cypress/cyfmac43455-sdio-standard.bin
49+
\ No newline at end of file
50+
diff --git a/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,4-compute-module.bin b/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,4-compute-module.bin
51+
index 9c39208..b914838 120000
52+
--- a/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,4-compute-module.bin
53+
+++ b/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,4-compute-module.bin
54+
@@ -1 +1 @@
55+
-../cypress/cyfmac43455-sdio.bin
56+
\ No newline at end of file
57+
+../cypress/cyfmac43455-sdio-standard.bin
58+
\ No newline at end of file
59+
diff --git a/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.bin b/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.bin
60+
index 9c39208..b914838 120000
61+
--- a/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.bin
62+
+++ b/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,4-model-b.bin
63+
@@ -1 +1 @@
64+
-../cypress/cyfmac43455-sdio.bin
65+
\ No newline at end of file
66+
+../cypress/cyfmac43455-sdio-standard.bin
67+
\ No newline at end of file
68+
diff --git a/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,5-model-b.bin b/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,5-model-b.bin
69+
index 9c39208..b914838 120000
70+
--- a/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,5-model-b.bin
71+
+++ b/debian/config/brcm80211/brcm/brcmfmac43455-sdio.raspberrypi,5-model-b.bin
72+
@@ -1 +1 @@
73+
-../cypress/cyfmac43455-sdio.bin
74+
\ No newline at end of file
75+
+../cypress/cyfmac43455-sdio-standard.bin
76+
\ No newline at end of file
77+
--
78+
2.34.1
79+

recipes-kernel/linux-firmware-rpidistro/linux-firmware-rpidistro_git.bb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ LICENSE_FLAGS = "synaptics-killswitch"
1717

1818
SRC_URI = "git://github.com/RPi-Distro/firmware-nonfree;branch=bookworm;protocol=https \
1919
file://0001-Default-43455-firmware-to-standard-variant.patch \
20+
file://0002-Default-all-RPi-43455-boards-to-standard-variant.patch \
2021
"
2122
SRCREV = "4b356e134e8333d073bd3802d767a825adec3807"
2223
PV = "20230625-2+rpt3"

0 commit comments

Comments
 (0)