Skip to content

Commit 9d404f0

Browse files
committed
docs: review with AI-7 [skip ci]
1 parent 32f2f50 commit 9d404f0

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ _There are no required inputs. The action only controls that the combination of
121121
| npm-visibility | public | Used together with env variable `NPM_TOKEN` to publish npm package. Specifies package visibility: public or private (not tested yet). [Example](./docs/artifact-types/npmjs.md) |
122122
| node-version | 22 | Node.js version to publish npm packages. Default is 22 because it is the highest pre-cached in Ubuntu 24 (latest at time of writing) |
123123
| java-version | 21 | Java version to use with input `aws-codeartifact-maven`. [Example](./docs/artifact-types/aws-codeartifact-maven.md) |
124-
| pre-publish-script | | Custom sh script that allows you to update version in arbitrary file(s), not only files governed by build tool (pom.xml, package.json, etc.). In this script you can use variable `$version`. See example in [npmjs](./docs/artifact-types/npmjs.md) |
124+
| pre-publish-script | | Custom shell script that allows you to update version in arbitrary file(s), not only files governed by build tool (pom.xml, package.json, etc.). In this script you can use variable `$version`. See example in [npmjs](./docs/artifact-types/npmjs.md) |
125125
| release-branches | (see description) | Semantic-release [branches](https://semantic-release.gitbook.io/semantic-release/usage/configuration#branches), mainly used to support [maintenance releases](./docs/features/maintenance-release.md) and [prereleases](./docs/features/prerelease.md) |
126126
| release-channel | | Repeat `.releaserc.json` `channel` behavior when `version` is set explicitly. See [floating-tags](./docs/features/floating-tags.md) for details |
127127
| release-gh | true | If true, then create a GitHub release |

action.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ inputs:
3030
description: 'Required if uploading to S3 (i.e. s3/ directory exists)'
3131
required: false
3232
aws-s3-dir:
33-
description: 'Allows to specify S3 bucket directory to upload artifacts to. By default just place in `bucket/{repo-name}/{version}/*`'
33+
description: 'Allows you to specify S3 bucket directory to upload artifacts to. By default, just place in `bucket/{repo-name}/{version}/*`'
3434
required: false
3535
changelog-file:
3636
description: 'Changelog file path. Pass empty string to disable changelog generation'
@@ -68,7 +68,7 @@ inputs:
6868
required: false
6969
default: 'public'
7070
pre-publish-script:
71-
description: 'sh script that allows you to update version in custom file(s), not only files governed by build tool (pom.xml, package.json, etc)'
71+
description: 'Shell script that allows you to update version in custom file(s), not only files governed by build tool (pom.xml, package.json, etc)'
7272
required: false
7373
release-branches:
7474
description: 'semantic-release "branches" configuration'
@@ -94,7 +94,7 @@ inputs:
9494
description: 'Explicit version to use instead of auto-generation'
9595
required: false
9696
version-bump:
97-
description: 'Allows to bump a version w/o semantic commits'
97+
description: 'Allows you to bump a version without semantic commits'
9898
required: false
9999

100100
runs:
@@ -117,7 +117,7 @@ runs:
117117
if: inputs.release-gh == 'true' && inputs.dev-release != 'true' && !env.GH_TOKEN
118118
shell: bash
119119
run: |
120-
echo "Error: env: GH_TOKEN is required to create GH release, you can pass $ {{ github.token }} or PAT" >&2; exit 1
120+
echo "Error: env variable GH_TOKEN is required to create GH release, you can pass $ {{ github.token }} or PAT" >&2; exit 1
121121
122122
- name: Validate npm visibility
123123
if : env.NPM_TOKEN && ! (inputs.npm-visibility == 'public' || inputs.npm-visibility == 'private')

docs/best-practices.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Best practices
22

33
- [Build and Release](#build-and-release)
4-
- [conventional commits](#conventional-commits)
4+
- [Conventional commits](#conventional-commits)
55
- [Company-specific gha-release wrapper](#company-specific-gha-release-wrapper)
66

77
## Build and Release
@@ -52,7 +52,7 @@ jobs:
5252
# Build/Package the artifact(s)
5353

5454
- name: Upload artifacts
55-
if: inputs.artifacts # no sense to upload artifacts on every push in a feature branch
55+
if: inputs.artifacts # no point in uploading artifacts on every push in a feature branch
5656
uses: actions/upload-artifact@v4
5757
with: # configure what to upload
5858
```
@@ -79,7 +79,7 @@ jobs:
7979
Release:
8080
needs: Build
8181
runs-on: ubuntu-latest
82-
environment: release # hold `GH_TOKEN` secret, available only for `main` branch
82+
environment: release # holds the `GH_TOKEN` secret, available only for `main` branch
8383
permissions:
8484
contents: read # required for checkout
8585
id-token: write # not always required, only if at some step you assume AWS role via OIDC
@@ -97,7 +97,7 @@ jobs:
9797
GH_TOKEN: ${{ secrets.GH_TOKEN }} # required to push commit and tags
9898
```
9999
100-
## conventional commits
100+
## Conventional commits
101101
102102
`agilecustoms/release` uses [semantic-release](https://github.com/semantic-release/semantic-release)
103103
for next version generation. semantic-release has several presets for different commit message conventions.
@@ -135,12 +135,12 @@ Non-default presets require additional npm dependency. This is why in many examp
135135
npm-extra-deps: conventional-changelog-conventionalcommits@9.1.0
136136
```
137137

138-
For more details see [semantic commits](./features/semantic-commits.md)
138+
For more details see [Semantic commits](./features/semantic-commits.md)
139139

140140
## Company-specific gha-release wrapper
141141

142142
In many [examples](./examples) you may some inputs repeat, such as `aws-account`, `aws-region`, `aws-role`.
143-
You can reduce code reputation by creating your own wrapper around `agilecustoms/release`.
143+
You can reduce code repetition by creating your own wrapper around `agilecustoms/release`.
144144
For this just create a new GH repo with single file `action.yml`, see example [gha-release](./examples/gha-release).
145145
Here you provide company-specific defaults, see comment `# company-specific defaults`.
146146
For parameters that may vary - you add them in `inputs` section and pass them through, see comment `# pass through inputs`.

0 commit comments

Comments
 (0)