|
1 | 1 | # Best practices |
2 | 2 |
|
3 | 3 | - [Build and Release](#build-and-release) |
4 | | -- [conventional commits](#conventional-commits) |
| 4 | +- [Conventional commits](#conventional-commits) |
5 | 5 | - [Company-specific gha-release wrapper](#company-specific-gha-release-wrapper) |
6 | 6 |
|
7 | 7 | ## Build and Release |
|
52 | 52 | # Build/Package the artifact(s) |
53 | 53 |
|
54 | 54 | - name: Upload artifacts |
55 | | - if: inputs.artifacts # no sense to upload artifacts on every push in a feature branch |
| 55 | + if: inputs.artifacts # no point in uploading artifacts on every push in a feature branch |
56 | 56 | uses: actions/upload-artifact@v4 |
57 | 57 | with: # configure what to upload |
58 | 58 | ``` |
|
79 | 79 | Release: |
80 | 80 | needs: Build |
81 | 81 | runs-on: ubuntu-latest |
82 | | - environment: release # hold `GH_TOKEN` secret, available only for `main` branch |
| 82 | + environment: release # holds the `GH_TOKEN` secret, available only for `main` branch |
83 | 83 | permissions: |
84 | 84 | contents: read # required for checkout |
85 | 85 | id-token: write # not always required, only if at some step you assume AWS role via OIDC |
|
97 | 97 | GH_TOKEN: ${{ secrets.GH_TOKEN }} # required to push commit and tags |
98 | 98 | ``` |
99 | 99 |
|
100 | | -## conventional commits |
| 100 | +## Conventional commits |
101 | 101 |
|
102 | 102 | `agilecustoms/release` uses [semantic-release](https://github.com/semantic-release/semantic-release) |
103 | 103 | for next version generation. semantic-release has several presets for different commit message conventions. |
@@ -135,12 +135,12 @@ Non-default presets require additional npm dependency. This is why in many examp |
135 | 135 | npm-extra-deps: conventional-changelog-conventionalcommits@9.1.0 |
136 | 136 | ``` |
137 | 137 |
|
138 | | -For more details see [semantic commits](./features/semantic-commits.md) |
| 138 | +For more details see [Semantic commits](./features/semantic-commits.md) |
139 | 139 |
|
140 | 140 | ## Company-specific gha-release wrapper |
141 | 141 |
|
142 | 142 | In many [examples](./examples) you may some inputs repeat, such as `aws-account`, `aws-region`, `aws-role`. |
143 | | -You can reduce code reputation by creating your own wrapper around `agilecustoms/release`. |
| 143 | +You can reduce code repetition by creating your own wrapper around `agilecustoms/release`. |
144 | 144 | For this just create a new GH repo with single file `action.yml`, see example [gha-release](./examples/gha-release). |
145 | 145 | Here you provide company-specific defaults, see comment `# company-specific defaults`. |
146 | 146 | For parameters that may vary - you add them in `inputs` section and pass them through, see comment `# pass through inputs`. |
|
0 commit comments