feat(session): add tests for session deletion (#179)

# Description

Add tests for session deletion.

Signed-off-by: Mauro Sardara <[email protected]>

Author: msardara

Diff for: data-plane/gateway/service/src/fire_and_forget.rs

@@ -173,4 +173,23 @@ mod tests {
         assert_eq!(msg.message, message);
         assert_eq!(msg.info.id, 1);
     }
+
+    #[tokio::test]
+    async fn test_session_delete() {
+        let (tx_gw, _) = tokio::sync::mpsc::channel(1);
+        let (tx_app, _) = tokio::sync::mpsc::channel(1);
+
+        let source = Agent::from_strings("cisco", "default", "local_agent", 0);
+
+        {
+            let _session = FireAndForget::new(
+                0,
+                FireAndForgetConfiguration {},
+                SessionDirection::Bidirectional,
+                source,
+                tx_gw,
+                tx_app,
+            );
+        }
+    }
 }

Diff for: data-plane/gateway/service/src/request_response.rs

@@ -369,4 +369,28 @@ mod tests {
             _ => panic!("unexpected error"),
         }
     }
+
+    #[tokio::test]
+    async fn test_session_delete() {
+        let (tx_gw, _) = tokio::sync::mpsc::channel(1);
+        let (tx_app, _) = tokio::sync::mpsc::channel(1);
+
+        let session_config = RequestResponseConfiguration {
+            max_retries: 0,
+            timeout: std::time::Duration::from_millis(1000),
+        };
+
+        let source = Agent::from_strings("cisco", "default", "local_agent", 0);
+
+        {
+            let _session = RequestResponse::new(
+                0,
+                session_config,
+                SessionDirection::Bidirectional,
+                source,
+                tx_gw,
+                tx_app,
+            );
+        }
+    }
 }

Diff for: data-plane/gateway/service/src/session_layer.rs

@@ -402,6 +402,30 @@ mod tests {
         assert!(res.is_ok());
     }
 
+    #[tokio::test]
+    async fn test_delete_session() {
+        let (tx_gw, _) = tokio::sync::mpsc::channel(1);
+        let (tx_app, _) = tokio::sync::mpsc::channel(1);
+        let agent = Agent::from_strings("org", "ns", "type", 0);
+
+        let session_layer = SessionLayer::new(&agent, 0, tx_gw.clone(), tx_app.clone());
+
+        let res = session_layer
+            .create_session(
+                SessionConfig::FireAndForget(FireAndForgetConfiguration {}),
+                Some(1),
+            )
+            .await;
+        assert!(res.is_ok());
+
+        let res = session_layer.remove_session(1).await;
+        assert!(res);
+
+        // try to delete a non-existing session
+        let res = session_layer.remove_session(1).await;
+        assert!(!res);
+    }
+
     #[tokio::test]
     async fn test_handle_message() {
         let (tx_gw, _) = tokio::sync::mpsc::channel(1);

Diff for: data-plane/gateway/service/src/streaming.rs

@@ -412,6 +412,11 @@ impl Streaming {
                     }
                 }
             }
+
+            debug!(
+                "stopping message processing on streaming session {}",
+                session_id
+            );
         });
     }
 }
@@ -1360,4 +1365,35 @@ mod tests {
             )
         );
     }
+
+    #[tokio::test]
+    #[traced_test]
+    async fn test_session_delete() {
+        let (tx_gw, _) = tokio::sync::mpsc::channel(1);
+        let (tx_app, _) = tokio::sync::mpsc::channel(1);
+
+        let source = Agent::from_strings("cisco", "default", "local_agent", 0);
+
+        let session_config: StreamingConfiguration =
+            StreamingConfiguration::new(SessionDirection::Sender, None, None, None);
+
+        {
+            let _session = Streaming::new(
+                0,
+                session_config.clone(),
+                SessionDirection::Sender,
+                source.clone(),
+                tx_gw.clone(),
+                tx_app.clone(),
+            );
+        }
+
+        // session should be deleted, make sure the process loop is also closed
+        time::sleep(Duration::from_millis(100)).await;
+
+        // check that the session is deleted, by checking the log
+        assert!(logs_contain(
+            "stopping message processing on streaming session 0"
+        ));
+    }
 }