feat: add checks for helm charts (#49)

Signed-off-by: Mauro Sardara <[email protected]>

Author: msardara

.github/actions/setup-k8s/action.yaml

@@ -0,0 +1,76 @@
+# SPDX-FileCopyrightText: Copyright (c) 2025 Cisco and/or its affiliates.
+# SPDX-License-Identifier: Apache-2.0
+
+---
+name: Setup Kubernetes tooling
+description: Setup Kubernetes tooling
+inputs:
+  helm-version:
+    description: 'Helm version'
+    required: false
+    default: "3.12.1"
+  helm-ct-version:
+    description: 'Helm chart-testing version'
+    required: false
+    default: "3.11.0"
+  kind-version:
+    description: 'Kind version'
+    required: false
+    default: "0.24.0"
+  kind-create-cluster:
+    description: 'Create kind K8s cluster'
+    required: false
+    default: "false"
+  kind-cluster-name:
+    description: 'Kind K8s cluster name to create'
+    required: false
+    default: "kind"
+  kind-cluster-gateway:
+    description: 'Gateway IP to use for kind server nodes. Useful when running actions inside containers.'
+    required: false
+    default: "127.0.0.1"
+runs:
+  using: "composite"
+  steps:
+    #
+    # Install kubernetes tools
+    #
+    - name: Setup Helm
+      uses: azure/setup-helm@fe7b79cd5ee1e45176fcad797de68ecaf3ca4814 # v4.2.0
+      with:
+        version: ${{ inputs.helm-version }}
+
+    - name: Set up Helm chart-testing
+      uses: helm/chart-testing-action@e6669bcd63d7cb57cb4380c33043eebe5d111992 # v2.6.1
+      with:
+        version: ${{ inputs.helm-ct-version }}
+
+    - name: Setup kind
+      uses: helm/kind-action@0025e74a8c7512023d06dc019c617aa3cf561fde # v1.10.0
+      with:
+        version: v${{ inputs.kind-version }}
+        install_only: true
+
+    - name: Setup kubectl
+      uses: azure/setup-kubectl@3e0aec4d80787158d308d7b364cb1b702e7feb7f # v4.0.0
+
+    #
+    # Setup cluster
+    #
+    - name: Setup Kind cluster
+      if: ${{ inputs.kind-create-cluster == 'true' }}
+      shell: bash
+      run: |
+        # Create cluster config
+        KIND_CONFIG_FILE=$(mktemp -p /tmp)
+        cat <<EOF > $KIND_CONFIG_FILE
+        kind: Cluster
+        apiVersion: kind.x-k8s.io/v1alpha4
+        networking:
+          apiServerAddress: "${{ inputs.kind-cluster-gateway }}"
+          apiServerPort: 6443
+        EOF
+
+        # Create cluster
+        kind create cluster --config $KIND_CONFIG_FILE --name ${{ inputs.kind-cluster-name }}
+        kubectl cluster-info

.github/release-config.json

@@ -3,12 +3,15 @@
     "separate-pull-requests": true,
     "sequential-calls": true,
     "include-component-in-tag": true,
-    "release-type": "python",
     "skip-github-release": false,
     "packages": {
         "data-plane/python-bindings": {
             "package-name": "agp-bindings",
             "release-type": "python"
+        },
+        "charts/agp": {
+            "package-name": "agp-helm",
+            "release-type": "helm"
         }
     }
 }

.github/release-manifest.json

@@ -1,3 +1,4 @@
 {
-    "data-plane/python-bindings": "0.1.5"
+    "data-plane/python-bindings": "0.1.5",
+    "charts/agp": "0.1.0"
 }

.github/workflows/helm-charts.yaml

@@ -0,0 +1,27 @@
+# SPDX-FileCopyrightText: Copyright (c) 2025 Cisco and/or its affiliates.
+# SPDX-License-Identifier: Apache-2.0
+
+---
+name: ci-test-and-build-helm-charts
+
+on:
+  push:
+    paths:
+      - 'charts/**'
+    branches:
+      - main
+  pull_request:
+    paths:
+      - 'charts/**'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
+jobs:
+  helm-chart-lint-test:
+    name: Helm charts lint & test
+    uses: ./.github/workflows/reusable-helm-lint-test.yaml
+    with:
+      chart-path: charts
+      dependencies: ""

.github/workflows/release-check.yaml

@@ -0,0 +1,28 @@
+# SPDX-FileCopyrightText: Copyright (c) 2025 Cisco and/or its affiliates.
+# SPDX-License-Identifier: Apache-2.0
+
+---
+name: ci-release-python
+
+on:
+  push:
+    branches:
+      - main
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
+jobs:
+  release:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+      pull-requests: write
+    steps:
+      - uses: googleapis/release-please-action@v4
+        id: release-please
+        with:
+          token: ${{ secrets.AGNTCY_BUILD_BOT_GH_TOKEN }}
+          config-file: .github/release-config.json
+          manifest-file: .github/release-manifest.json

.github/workflows/release-helm.yaml

@@ -25,7 +25,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Relesae
+      - name: Resolve release tag
         id: resolve
         run: |
           echo "release_tag=$(echo ${GITHUB_REF#refs/*/} | sed 's/^agp-helm-//')" >> $GITHUB_OUTPUT
@@ -43,4 +43,4 @@ jobs:
       registry: ghcr.io/agntcy/agp
       release_tag: ${{ needs.prepare-build.outputs.release_tag }}
     secrets:
-      github-token: ${{ secrets.GITHUB_TOKEN }}
+      github-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/release-python.yaml

@@ -18,23 +18,6 @@ concurrency:
   cancel-in-progress: ${{ github.event_name == 'pull_request' }}
 
 jobs:
-  release:
-    runs-on: ubuntu-latest
-    if: github.event_name == 'push'
-    permissions:
-      contents: write
-      pull-requests: write
-    outputs:
-      releases_created: ${{ steps.release-please.outputs.releases_created }}
-      released_paths: ${{ steps.release-please.outputs.paths_released }}
-    steps:
-      - uses: googleapis/release-please-action@v4
-        id: release-please
-        with:
-          token: ${{ secrets.AGNTCY_BUILD_BOT_GH_TOKEN }}
-          config-file: .github/release-config.json
-          manifest-file: .github/release-manifest.json
-
   build-wheels:
     name: Data plane - Python wheels
     uses: ./.github/workflows/reusable-python-build-wheels.yaml

.github/workflows/reusable-helm-lint-test.yaml

@@ -0,0 +1,77 @@
+# SPDX-FileCopyrightText: Copyright (c) 2025 Cisco and/or its affiliates.
+# SPDX-License-Identifier: Apache-2.0
+
+---
+name: Lint / Test Helm Chart
+
+on:
+  workflow_call:
+    inputs:
+      chart-path:
+        description: "Path to the chart to lint"
+        required: true
+        type: string
+      config-file:
+        description: "Path to the chart-testing config file"
+        required: false
+        type: string
+        default: ""
+      dependencies:
+        description: "List of dependencies to add"
+        required: false
+        default: ""
+        type: string
+
+
+jobs:
+  lint-test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+          submodules: "true"
+
+      - name: Print chart path
+        run: |
+          echo "Chart path: ${{ inputs.chart-path }}"
+
+      - name: Setup K8s
+        uses: ./.github/actions/setup-k8s
+        with:
+          kind-create-cluster: true
+
+      - name: Add dependencies
+        shell: bash
+        run: |
+          IFS='\n' readarray -t dependencies <<< "${{ inputs.dependencies }}"
+          for dependency in "${dependencies[@]}"; do
+            # Skip line if it is empty
+            if [[ -z "${dependency//[[:space:]]/}" ]]; then
+              continue
+            fi
+
+            # Split the dependency into name and repo
+            IFS='@' read -r name repo <<< "${dependency}"
+
+            echo helm repo add ${name} ${repo}
+          done
+
+      - name: Run chart-testing (lint & test)
+        run: |
+          args=(
+            --upgrade
+            --debug
+            --target-branch=${{ github.base_ref }}
+            --chart-dirs ${{ inputs.chart-path }}
+            --validate-maintainers=false
+            --check-version-increment=false
+          )
+
+          if [[ -f "${{ inputs.config-file }}" ]]; then
+            args+="--config ${{ inputs.config-file }}"
+          fi
+
+          ct lint-and-install ${args[@]}

.github/workflows/reusable-helm-release.yaml

@@ -1,6 +1,7 @@
 # SPDX-FileCopyrightText: Copyright (c) 2025 Cisco and/or its affiliates.
 # SPDX-License-Identifier: Apache-2.0
 
+---
 name: Release
 
 on:
@@ -48,7 +49,7 @@ jobs:
 
       - name: Helm lint
         shell: bash
-        run: helm lint deploy/charts/agp --with-subcharts
+        run: helm lint charts/agp --with-subcharts
 
       - name: Set chart name
         id: chart-name
@@ -59,7 +60,7 @@ jobs:
         id: build
         shell: bash
         run: |
-          helm package deploy/charts/agp --dependency-update --version ${{ inputs.release_tag }}
+          helm package charts/agp --dependency-update --version ${{ inputs.release_tag }}
           echo "package=${{ steps.chart-name.outputs.value }}-${{ inputs.release_tag }}.tgz" >> "$GITHUB_OUTPUT"
 
       - name: Helm push to GHCR OCI registry

deploy/charts/agp/.helmignore renamed to charts/agp/.helmignore

@@ -2,6 +2,7 @@
 # This supports shell glob matching, relative path matching, and
 # negation (prefixed with !). Only one pattern per line.
 .DS_Store
+
 # Common VCS dirs
 .git/
 .gitignore
@@ -10,12 +11,14 @@
 .hg/
 .hgignore
 .svn/
+
 # Common backup files
 *.swp
 *.bak
 *.tmp
 *.orig
 *~
+
 # Various IDEs
 .project
 .idea/

deploy/charts/agp/Chart.yaml renamed to charts/agp/Chart.yaml

@@ -1,6 +1,7 @@
 # SPDX-FileCopyrightText: Copyright (c) 2025 Cisco and/or its affiliates.
 # SPDX-License-Identifier: Apache-2.0
 
+---
 apiVersion: v2
 name: agp
 description: A Helm chart for Kubernetes
@@ -24,4 +25,4 @@ version: 0.1.0
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "0.1.1"
+appVersion: "0.3.0"