Skip to content

Commit dee7844

Browse files
committed
fix: ping logo
Signed-off-by: Rafael Silva (rafaelsi) <rafaelsi@cisco.com>
1 parent aab5d5a commit dee7844

5 files changed

Lines changed: 7 additions & 16 deletions

File tree

frontend/src/assets/ping.jpg

94.8 KB
Loading

frontend/src/assets/ping.svg

Lines changed: 0 additions & 5 deletions
This file was deleted.

frontend/src/components/identity-provider/create/form/identity-provider-form.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import DuoLogo from '@/assets/duo.svg?react';
1616
import OktaLogo from '@/assets/okta.svg?react';
1717
import OasfLogo from '@/assets/oasf.svg?react';
1818
import OryLogo from '@/assets/ory.svg?react';
19-
import PingLogo from '@/assets/ping.svg?react';
19+
import PingLogo from '@/assets/ping.jpg';
2020
import KeycloakLogo from '@/assets/keycloak.png';
2121
import EntraLogo from '@/assets/entra.svg?react';
2222
import {IdpType} from '@/types/api/settings';
@@ -76,7 +76,7 @@ export const IdentityProviderForm = ({isLoading = false}: {isLoading?: boolean})
7676
{
7777
type: IdpType.IDP_TYPE_PING,
7878
title: 'Ping',
79-
imgURI: <PingLogo />,
79+
imgURI: <img src={PingLogo} alt="Ping Logo" className="w-6 h-6" />,
8080
isDisabled: isLoading || !isEmptyIdp,
8181
useTooltip: isEmptyIdp
8282
},

frontend/src/components/shared/identity-provider/provider-type.test.tsx

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,8 @@ vi.mock('@/assets/ory.svg?react', () => ({
5555
))
5656
}));
5757

58-
vi.mock('@/assets/ping.svg?react', () => ({
59-
default: vi.fn((props) => (
60-
<svg data-testid="ping-logo" {...props}>
61-
<title>Ping Logo</title>
62-
</svg>
63-
))
58+
vi.mock('@/assets/ping.jpg', () => ({
59+
default: 'ping-logo.jpg'
6460
}));
6561

6662
// Mock constants - use string literals instead of enum references
@@ -186,7 +182,7 @@ describe('ProviderType', () => {
186182
it('renders Ping logo and label', () => {
187183
render(<ProviderType type={IdpType.IDP_TYPE_PING} />);
188184

189-
const pingLogo = screen.getByTestId('ping-logo');
185+
const pingLogo = screen.getByAltText('Ping');
190186
expect(pingLogo).toBeInTheDocument();
191187
expect(pingLogo).toHaveClass('h-[22px] w-[22px]');
192188

frontend/src/components/shared/identity-provider/provider-type.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import DuoLogo from '@/assets/duo.svg?react';
1010
import OktaLogo from '@/assets/okta.svg?react';
1111
import OasfLogo from '@/assets/oasf.svg?react';
1212
import OryLogo from '@/assets/ory.svg?react';
13-
import PingLogo from '@/assets/ping.svg?react';
13+
import PingLogo from '@/assets/ping.jpg';
1414
import EntraLogo from '@/assets/entra.svg?react';
1515
import {IdpType} from '@/types/api/settings';
1616
import KeycloakLogo from '@/assets/keycloak.png';
@@ -24,7 +24,7 @@ export const ProviderType = ({type, className}: {type?: IdpType; className?: str
2424
{type === IdpType.IDP_TYPE_ORY && <OryLogo className="h-[22px] w-[22px]" />}
2525
{type === IdpType.IDP_TYPE_ENTRA_ID && <EntraLogo className="h-[20px] w-[20px]" />}
2626
{type === IdpType.IDP_TYPE_KEYCLOAK && <img src={KeycloakLogo} alt="Keycloak" className="h-[20px] w-[20px]" />}
27-
{type === IdpType.IDP_TYPE_PING && <PingLogo className="h-[22px] w-[22px]" />}
27+
{type === IdpType.IDP_TYPE_PING && <img src={PingLogo} alt="Ping" className="h-[22px] w-[22px]" />}
2828
<Typography
2929
variant="body1"
3030
fontSize={14}

0 commit comments

Comments
 (0)