Skip to content

Commit 9cab6d5

Browse files
authored
fix: separate server connection config (#1778)
closes #1640 # Description The PR separates server-side connection requirements from client connection policy by introducing `ServerConnectionConfig` as a dedicated type, distinct from `ClientConfig`. Previously, the full `ClientConfig` (including client-local settings like Spire socket paths, backoff, keepalive) was serialized and stored in the database and passed over the wire. Now the control plane stores and transmits only what the server requires — endpoint, TLS flag, and auth method — while the controller merges those requirements onto its own local ClientConfig when opening a connection. # Changes - Dedicated `ServerConnectionConfig` type containing only remote connection related fields - In `ConnectionDetails` db schema `SpireMtls` nested field is replaced with three flat fields (`tls_required`, `auth_method` and `spire_trust_domain`) - `generate_config_data` simplified: unused `src_node` removed - `tls_required == true` is now mandatory if `auth_method` is Spire ## Type of Change - [ ] Bugfix - [ ] New Feature - [x] Breaking Change - [ ] Refactor - [ ] Documentation - [ ] Other (please describe) ## Checklist - [x] I have read the [contributing guidelines](/agntcy/repo-template/blob/main/CONTRIBUTING.md) - [x] Existing issues have been referenced (where applicable) - [x] I have verified this change is not present in other open pull requests - [x] Functionality is documented - [x] All code style checks pass - [x] New code contribution is covered by automated tests - [x] All new and existing tests pass --------- Signed-off-by: Mark Marton <mark.p.marton@gmail.com> Signed-off-by: Mark Marton <30534230+markpmarton@users.noreply.github.com>
1 parent 3d232c3 commit 9cab6d5

25 files changed

Lines changed: 1623 additions & 366 deletions

File tree

buf.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,18 @@ breaking:
2121
- data-plane/v1/data_plane.proto
2222
FIELD_SAME_NAME:
2323
- data-plane/v1/data_plane.proto
24+
- crates/proto/proto/controller/v1/controller.proto
2425
FIELD_SAME_TYPE:
2526
- data-plane/v1/data_plane.proto
27+
- crates/proto/proto/controller/v1/controller.proto
2628
FIELD_SAME_CARDINALITY:
2729
- data-plane/v1/data_plane.proto
30+
- crates/proto/proto/controller/v1/controller.proto
2831
FIELD_SAME_JSON_NAME:
2932
- data-plane/v1/data_plane.proto
33+
- crates/proto/proto/controller/v1/controller.proto
34+
MESSAGE_NO_DELETE:
35+
- crates/proto/proto/controller/v1/controller.proto
36+
- crates/proto/proto/controlplane/v1/controlplane.proto
37+
RPC_NO_DELETE:
38+
- crates/proto/proto/controlplane/v1/controlplane.proto

0 commit comments

Comments
 (0)