Handle a prov_type that isn't in the list of possibilities

Author: agrare

app/models/service_template.rb

@@ -145,14 +145,17 @@ def self.class_from_prov_type(prov_type)
     # class name validity before calling constantize.
     allowed_class_names = descendants.collect(&:name)
 
+    raise ArgumentError, "Invalid prov_type '#{prov_type}'" unless all_catalog_item_types.keys.include?(prov_type)
+
     # If we are given a "generic" provision type then assume that the prov_type
     # maps to a valid class otherwise it is invalid
     #
     # Non-generic provision types however are able to work with the base
     # ServiceTemplate class and thus we cannot raise an exception in this case.
     if prov_type.starts_with?("generic_")
-      class_name = request_type.split('generic_').last
-      raise NameError, _("uninitialized constant") unless allowed_class_names.include?(class_name)
+      generic_type = prov_type.split('generic_').last
+      class_name   = "ServiceTemplate#{generic_type.camelize}"
+      raise ArgumentError, "Invalid prov_type '#{prov_type}'" unless allowed_class_names.include?(class_name)
     else
       class_name = "ServiceTemplate#{prov_type.camelize}"
       class_name = "ServiceTemplate" unless allowed_class_names.include?(class_name)

spec/models/service_template_spec.rb

@@ -719,6 +719,34 @@
     end
   end
 
+  describe '.class_from_prov_type' do
+    it 'returns the correct generic type' do
+      template_class = ServiceTemplate.class_from_prov_type('generic_ansible_tower')
+
+      expect(template_class).to eq(ServiceTemplateAnsibleTower)
+    end
+
+    it 'raises an exception for an invalid generic type' do
+      expect { ServiceTemplate.class_from_prov_type('generic_invalid') }
+        .to raise_error(ArgumentError, /Invalid prov_type/)
+    end
+
+    it 'returns the correct non-generic type mapping to ::ServiceTemplate' do
+      template_class = ServiceTemplate.class_from_prov_type('amazon')
+
+      expect(template_class).to eq(ServiceTemplate)
+    end
+
+    it 'returns the correct non-generic type when mapping to a ServiceTemplate subclass' do
+      expect(ServiceTemplate.class_from_prov_type("awx")).to eq(ServiceTemplateAwx)
+    end
+
+    it 'raises an exception for an invalid non-generic type' do
+      expect { ServiceTemplate.class_from_prov_type('invalid') }
+        .to raise_error(ArgumentError, /Invalid prov_type/)
+    end
+  end
+
   let(:user) { FactoryBot.create(:user_with_group) }
   let(:ra1) { FactoryBot.create(:resource_action, :action => 'Provision') }
   let(:ra2) { FactoryBot.create(:resource_action, :action => 'Retirement') }