Global config seems to be ignored

[MichalBryxi]

This issue relates to my confusion in this issue, but the problem remains unresolved: No matter what I do I can't set global config for highcharts.

I created a file:

// app/highcharts-configs/application.js

export default function (defaultOptions) {
  defaultOptions.credits.href = null;
  defaultOptions.credits.text = null;
  defaultOptions.credits.enabled = false;

  return defaultOptions;
}

I can see that it's loaded:

But the Highchart(stock) does not honour credits.enabled = false (see the highcharts link in bottom right):

If I just pass

    credits: {
      enabled: false,
    },

To the option of given chart, it works ok. Just not globally.

Maybe this stems from the addon calling Highcharts.setOptions() which might work only for HighCharts, but does not for HighStock?

[RobbieTheWagner]

I think global config is tricky now that we are dynamically importing only the pieces you need. It means we don't have one giant global Highcharts to set options on and even when we do, it might point to a different type.

[MichalBryxi]

If we'd go in non-breaking way, I would guess that just taking the app/highcharts-configs/application.js and shoving it into any highcharts instance we want to make should do the trick? At least highcharts and highstocks pride themselves to be compatible, so should mostly work and it's what the people used till now?

1. But yeah to honour the fact that we have now N possible global configs (per chart type) we should do something like:

// app/highcharts-configs/application.js

export default function (defaultOptions) {
  defaultOptions['StockChart'].credits.href = null;
  defaultOptions['StockChart'].credits.text = null;
  defaultOptions['StockChart'].credits.enabled = false;

  return defaultOptions;
}

2. This could also have a global option defaultOptions['global'].foo as AFAIK many configuration options are globally available across all types of highcharts.

3. Tangential, but when we're here: Could we / should we move the config from app/highcharts-configs/application.js to something like config/ember-highcharts.js?

   • Random folder and file in /app just feels weird
   • highcharts-configs does not say which addon consumes said config. There could be other addon that does highcharts and it would be hard to tell.
   • It streamlines the way other addons do it (ember-intl for example).