Skip to content

Commit 173952c

Browse files
committed
Local https prevents testing on phone over LAN so not worth it
Not to mention the fact that incompetent Jekyll devs can't make `--livereload` work with https
1 parent a8fd985 commit 173952c

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

serve.sh

+16-16
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@ set -e
44

55
./build.sh --watch --no-jekyll
66

7-
crt="localhost.pem"
8-
key="localhost-key.pem"
9-
10-
if [[ ! -f "$crt" || ! -f "$key" ]]; then
11-
if command -v mkcert > /dev/null; then
12-
mkcert -install
13-
mkcert -cert-file "$crt" -key-file "$key" localhost 127.0.0.1 "::1" 0.0.0.0 192.168.1.100
14-
fi
15-
fi
16-
17-
if [[ -f "$crt" && -f "$key" ]]; then
18-
# Can't serve live reload script over https
19-
# https://github.com/jekyll/jekyll/issues/9495
20-
bundler exec jekyll serve --ssl-cert "$crt" --ssl-key "$key" "$@"
21-
else
7+
#crt="localhost.pem"
8+
#key="localhost-key.pem"
9+
#
10+
#if [[ ! -f "$crt" || ! -f "$key" ]]; then
11+
# if command -v mkcert > /dev/null; then
12+
# mkcert -install
13+
# mkcert -cert-file "$crt" -key-file "$key" localhost 127.0.0.1 "::1" 0.0.0.0 192.168.1.100
14+
# fi
15+
#fi
16+
#
17+
#if [[ -f "$crt" && -f "$key" ]]; then
18+
# # Can't serve live reload script over https
19+
# # https://github.com/jekyll/jekyll/issues/9495
20+
# bundler exec jekyll serve --ssl-cert "$crt" --ssl-key "$key" "$@"
21+
#else
2222
bundler exec jekyll serve --livereload "$@"
23-
fi
23+
#fi

0 commit comments

Comments
 (0)