You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Strengthen dimension label tests to verify label preservation
Address reviewer feedback: tests that claim label preservation or
propagation now explicitly verify the label string (via row_to_labels
or Shape.to_labels), not just absence of exceptions.
Key changes:
- Add get_var_label helper using Row.row_to_labels to inspect labels
- Add test 5b: verifies variable label upgrade in the environment
- Tests 1, 3: verify label visible in result shape via Shape.to_labels
- Tests 9, 11: restructure concat tests to use variable components
(triggers s_dim_one collapse), verify label="x" and d=5
- Tests 12, 14-17: verify label="x" on solved dims after affine/stride
arithmetic, not just absence of errors
- Test 18: assert definite Shape_error for mutual inequality with
conflicting labels, instead of accepting either outcome
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
0 commit comments