Feature request - Custom color for the text of links

[vladmark]

I want to be able to change the color of the actual text that has a link. Currently it is a dark blue. The reason I want it changed is that I use sioyek in dark_mode, and that color makes links almost unreadable against the black background.

I have looked through the documentation of all the preferences and I couldn't find this feature. I am not talking about link_highlight_color, that is the color of a box that is placed over links if toggle_highlights is set.

I imagine it would be a super useful feature for anybode else who uses dark mode. Could we please have this?

I'll submit an issue if somebody says it could be considered.

[ahrm]

It is not possible to change the link of text highlights because we are not the ones that are highlighting them, they are highlighted as part of the PDF file. You can use the custom color mode along with custom_color_contrast 1 config to fix this issue.

[vladmark]

Thank you for the reply. I toggled custom color mode and custom_color_contrast 1 doesn't seem to do anything, I set it in both prefs and user_prefs. Are you sure this option does anything? I haven't found it in the docs either.

However, if I set in prefs_user:

custom_background_color 0 0 0
custom_text_color 1 1 1

this makes links readable, in a gray-brown, and the background is black as in the dark mode.

So it is what I wanted, it solves my issue.

Now I am just curiouss how can what you say be true that "we are not the ones that are highlighting them" if I can obtain black background + white text + dark blue links with toggle_dark_mode, and black background + white text + gray-brown links with custom_color and the above settings? It seems clear from this that the reader software is the one controlling how the links are being displayed, no?

[ahrm]

Yes, custom_color_contrast does something.

In both dark mode and custom color mode we apply pixel-level post-processing to change the colors, with different algorithms. But we have no way of determining whether the current pixel is a link or not.

[vladmark]

Ah, I understand, so the reader does pixel level processing, agnostic of the functionality of the pdf element. That makes sense, thank you.

I still can't see any effect of custom_color_contrast 1, though; I put this line in prefs_user and it does nothing. I also set it to 0, 0.4, etc., and the pdf renders identically the same.