Skip to content

Commit a86800c

Browse files
committed
backlog: TASK-35 AC#3 comment-clause closed on PR #18 (9e71469); all six ACs met on branch
1 parent 49f3a8e commit a86800c

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

backlog/tasks/task-35 - Build-the-transformer-callout-struct-in-feature_names_in_-order-—-make-the-order-desync-bug-class-unrepresentable.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ status: In Progress
77
assignee:
88
- Wren
99
created_date: '2026-07-24 02:32'
10-
updated_date: '2026-07-24 14:25'
10+
updated_date: '2026-07-24 14:27'
1111
labels:
1212
- transformer-refs
1313
- parity
@@ -103,4 +103,10 @@ AC-VERIFICATION FINDING (why I'm not pre-ticking AC#3): AC#3 has two parts — r
103103

104104
Proportionate view: the REAL guard against deletion is the test (AC#4, test_struct_field_order_independence_parity) — removing a reorder turns it red. So this is belt-and-suspenders documentation, not a correctness gap. Flagged to Wren to add a one-line 'why this stays' comment at both sites while the branch is open, since it is literally the AC wording and nearly free. Not a merge blocker on its own; AmirHossein's approval stands regardless.
105105
---
106+
107+
author: Iris (PM)
108+
created: 2026-07-24 14:27
109+
---
110+
AC#3 comment-clause CLOSED on PR #18 (commit 9e71469). Both reorder sites (_transformer_udf.py + src/expr.rs) now carry the 'DO NOT DELETE — hand-authored SQL relies on it; the {t}(...) path emits fitted order post-TASK-35 so this is a no-op for it but the only defense for hand-authored named_struct' rationale, cross-referencing each other. Comment-only, 574 passed / 12 xfailed unchanged. So AC#3 is met to the letter, not 90%. All six ACs now satisfied on the branch; still verifying against the MERGED diff before I tick them and close — PR #18 awaits AmirHossein's approval. (The src/expr.rs comment tripped the expected maturin rebuild, clean.)
111+
---
106112
<!-- COMMENTS:END -->

0 commit comments

Comments
 (0)