ci: stop the review workflow cancelling itself - #12
Closed
ahrzb wants to merge 2 commits into
Closed
Conversation
track_progress posts a tracking comment as claude[bot]. That fired issue_comment again, matched the /review gate, and cancel-in-progress killed the human-triggered review (confirmed: run 30010567822 by ahrzb cancelled 16s later by 30010586182 by claude[bot]). Gate on a non-Bot comment author. allowed_bots is now dead config, so drop it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Blanket bot exclusion also blocked claude-agent-ahrzb[bot] from requesting reviews. Only claude[bot] posts comments (the loop source); the agent App only pushes, so exempting it cannot feed the self-cancel loop. Restores allowed_bots, which is live again for that path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Closing for now — we're not using the AI CI review workflow at the moment, so the self-cancel it fixes is moot. Worth knowing if it's ever turned back on: the workflow cancels its own review, because claude[bot]'s track_progress comment re-fires issue_comment, matches /review, and cancel-in-progress kills the run already in flight. The fix on this branch (excluding bot-authored comments, with our agent App exempted) still applies. |
|
Claude Code is working… I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
/reviewwas being killed by the reviewer's own comment.Cause (confirmed in the run history):
track_progress: truemakes claude[bot] post a tracking comment. That's anotherissue_comment: created, its body contains "/review", so it passed the gate and started a second run — andcancel-in-progress: truethen cancelled the human-triggered review.Fix: gate on a non-Bot comment author, so the workflow can't be re-triggered by its own bot comments.
Also drops
allowed_bots, which is now dead config (bot comments can't pass the gate at all). If we later want agents to/review, that needs a targeted exception rather than the blanket bot allowance.🤖 Generated with Claude Code