test: ...

Author: ahwayakchih

test/lib/writeCRX3File.js

@@ -218,8 +218,10 @@ async function doesItWorkInChrome (t, cfg) {
 	const margin = ' '.padStart(t._objectPrintDepth || 0, '.'); // eslint-disable-line no-underscore-dangle
 
 	// Since v112, Chrome/Chromium has "new" headless mode, which supports extensions and does not need XVFB
+	// But there are problems running it through GitHub Actions inside rootfull container,
+	// so allow to force using "full mode" by setting `CHROME_DISABLE_SANDBOX` in environment.
 	/* eslint-disable array-element-newline, array-bracket-newline, multiline-comment-style */
-	const runFullModeMode = !testVersion(chromeVersion.trim(), '112.0.5614.0');
+	const runFullModeMode = process.env.CHROME_DISABLE_SANDBOX || !testVersion(chromeVersion.trim(), '112.0.5614.0');
 	const browserIgnoreDefaultArgs = [
 		'--disable-extensions', // Do not disable extensions when we want to test them ;P
 		'--disable-background-networking' // Do not prevent browser from force_installing our stuff
@@ -229,7 +231,7 @@ async function doesItWorkInChrome (t, cfg) {
 		// Without this, puppeteer (or Chromium?) in Alpine container hangs and `newPage()` is never resolved nor failed.
 		'--disable-gpu'
 	];
-	if (true) {
+	if (runFullModeMode) {
 		t.comment(`${margin}Running full browser, XVFB is required`);
 		// Make sure we do not run in "old" headless mode because it disables support for extensions
 		browserIgnoreDefaultArgs.unshift('--headless');
@@ -250,10 +252,6 @@ async function doesItWorkInChrome (t, cfg) {
 	}
 	else {
 		t.comment(`${margin}Running browser using "new" headless mode, XVFB is not needed`);
-		// Running by GitHub Action in a rootful Docker sucks, and we have to bring back some of the old stuff.
-		if (process.env.CHROME_DISABLE_SANDBOX) {
-			browserArgs.push('--no-sandbox');
-		}
 	}
 	/* eslint-enable array-element-newline, array-bracket-newline, multiline-comment-style */