Skip to content

Commit daf7d15

Browse files
authored
test: ...
1 parent b29ee66 commit daf7d15

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/lib/writeCRX3File.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,8 @@ async function doesItWorkInChrome (t, cfg) {
217217

218218
const margin = ' '.padStart(t._objectPrintDepth || 0, '.'); // eslint-disable-line no-underscore-dangle
219219

220-
// Since v112, Chrome/Chromium has "new" headless mode, which supports extensions and does not need XVFB
221-
// But there are problems running it through GitHub Actions inside rootfull container,
220+
// Since v112, Chrome/Chromium has "new" headless mode, which supports extensions and does not need XVFB.
221+
// But there are problems running it by GitHub Actions (inside a rootful container),
222222
// so allow to force using "full mode" by setting `CHROME_DISABLE_SANDBOX` in environment.
223223
/* eslint-disable array-element-newline, array-bracket-newline, multiline-comment-style */
224224
const runFullModeMode = process.env.CHROME_DISABLE_SANDBOX || !testVersion(chromeVersion.trim(), '112.0.5614.0');
@@ -256,7 +256,7 @@ async function doesItWorkInChrome (t, cfg) {
256256
/* eslint-enable array-element-newline, array-bracket-newline, multiline-comment-style */
257257

258258
const browser = await puppeteer.launch({
259-
headless : false, // This has to be false, even when we're passing `headless=new` arg
259+
headless : false, // This has to be false, even when we're passing `headless=new` option
260260
executablePath : process.env.CHROME_BIN || null,
261261
ignoreDefaultArgs: browserIgnoreDefaultArgs,
262262
args : browserArgs

0 commit comments

Comments
 (0)