skip patch ObservedGeneration if no change (#337)

* skip patch ObservedGeneration if no change

Signed-off-by: xulinfei <xulinfei@bytedance.com>

* Adapt changes made in PCS and PCLQ controllers to PCSG controller.

Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

---------

Signed-off-by: xulinfei <xulinfei@bytedance.com>
Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>
Co-authored-by: xulinfei <xulinfei@bytedance.com>
Co-authored-by: Saketh Kalaga <saketh.kalaga@sap.com>

Author: 3 people

operator/internal/controller/podclique/reconcilespec.go

@@ -188,6 +188,10 @@ func (r *Reconciler) syncPCLQResources(ctx context.Context, logger logr.Logger,
 
 // updateObservedGeneration updates the PodClique status to reflect the current generation being processed
 func (r *Reconciler) updateObservedGeneration(ctx context.Context, logger logr.Logger, pclq *grovecorev1alpha1.PodClique) ctrlcommon.ReconcileStepResult {
+	if pclq.Status.ObservedGeneration != nil && *pclq.Status.ObservedGeneration == pclq.Generation {
+		return ctrlcommon.ContinueReconcile()
+	}
+
 	original := pclq.DeepCopy()
 	pclq.Status.ObservedGeneration = &pclq.Generation
 	if err := r.client.Status().Patch(ctx, pclq, client.MergeFrom(original)); err != nil {

operator/internal/controller/podcliquescalinggroup/reconcilespec.go

@@ -158,6 +158,10 @@ func (r *Reconciler) recordIncompleteReconcile(ctx context.Context, logger logr.
 
 // updateObservedGeneration updates the PodCliqueScalingGroup status to reflect the current generation being processed
 func (r *Reconciler) updateObservedGeneration(ctx context.Context, logger logr.Logger, pcsg *grovecorev1alpha1.PodCliqueScalingGroup) ctrlcommon.ReconcileStepResult {
+	if pcsg.Status.ObservedGeneration != nil && *pcsg.Status.ObservedGeneration == pcsg.Generation {
+		return ctrlcommon.ContinueReconcile()
+	}
+
 	original := pcsg.DeepCopy()
 	pcsg.Status.ObservedGeneration = &pcsg.Generation
 	if err := r.client.Status().Patch(ctx, pcsg, client.MergeFrom(original)); err != nil {

operator/internal/controller/podcliqueset/reconcilespec.go

@@ -176,6 +176,10 @@ func (r *Reconciler) syncPodCliqueSetResources(ctx context.Context, logger logr.
 
 // updateObservedGeneration updates the status to reflect the current observed generation.
 func (r *Reconciler) updateObservedGeneration(ctx context.Context, logger logr.Logger, pcs *grovecorev1alpha1.PodCliqueSet) ctrlcommon.ReconcileStepResult {
+	if pcs.Status.ObservedGeneration != nil && *pcs.Status.ObservedGeneration == pcs.Generation {
+		return ctrlcommon.ContinueReconcile()
+	}
+
 	original := pcs.DeepCopy()
 	pcs.Status.ObservedGeneration = &pcs.Generation
 	if err := r.client.Status().Patch(ctx, pcs, client.MergeFrom(original)); err != nil {