Skip to content

ImportStr return value not checked in libfabric rail manager #1160

@dmvevents

Description

@dmvevents

Description

In libfabric_rail_manager.cpp, the return value of importStr() is not checked, allowing corrupted metadata to proceed and cause crashes later.

Environment

  • NIXL 0.8.0
  • libfabric backend

File

src/utils/libfabric/libfabric_rail_manager.cpp

Current Code

ser_des.importStr(serialized_data);
// No check of return value - corrupted data proceeds

Proposed Fix

nixl_status_t import_status = ser_des.importStr(serialized_data);
if (import_status != NIXL_SUCCESS) {
    NIXL_WARN << "importStr failed, metadata may be corrupted";
    return NIXL_ERR_MISMATCH;
}

Impact

Corrupted metadata causes crashes during rail initialization instead of failing gracefully.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions