Skip to content

Remove unused {dir} parameter from sidecar pattern formatting#5

Draft
Copilot wants to merge 2 commits intoadding-configs-and-docsfrom
copilot/sub-pr-4
Draft

Remove unused {dir} parameter from sidecar pattern formatting#5
Copilot wants to merge 2 commits intoadding-configs-and-docsfrom
copilot/sub-pr-4

Conversation

Copy link
Copy Markdown

Copilot AI commented Dec 23, 2025

The resolve_sidecar_path() function was passing a dir argument to pattern.format() that no pattern actually used, triggering a surplus argument warning.

Changes:

  • Removed dir=str(parent) from the format call in config.py
  • Removed {dir} from function docstring and both documentation files

The function already prepends parent directories automatically for relative paths, so this parameter was redundant:

# These patterns work without {dir} - parent is joined automatically
resolve_sidecar_path(Path("src/foo.py"), "{stem}.history.yaml")
# → src/foo.history.yaml

resolve_sidecar_path(Path("src/foo.py"), ".history/{name}.yaml")  
# → src/.history/foo.py.yaml

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: cmungall <50745+cmungall@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Dec 23, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • astral.sh
    • Triggering command: /usr/bin/curl curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback on configs and docs from previous PR review Remove unused {dir} parameter from sidecar pattern formatting Dec 23, 2025
Copilot AI requested a review from cmungall December 23, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants