|
| 1 | +Summary |
| 2 | + |
| 3 | +This PR obsoletes GO:0008785 "alkyl hydroperoxide reductase activity" and replaces it with GO:0102039 "NADH-dependent peroxiredoxin activity", as requested in issue #31961. |
| 4 | + |
| 5 | +Changes made |
| 6 | + |
| 7 | +- Obsoleted GO:0008785. |
| 8 | + - name -> "obsolete alkyl hydroperoxide reductase activity" |
| 9 | + - definition -> prefixed with "OBSOLETE." |
| 10 | + - removed active classification |
| 11 | + - added obsoletion comment |
| 12 | + - added `is_obsolete: true` |
| 13 | + - added `replaced_by: GO:0102039` |
| 14 | + - added `term_tracker_item` for issue #31961 |
| 15 | +- Updated GO:0102039. |
| 16 | + - transferred the original GO:0008785 label as an EXACT synonym: "alkyl hydroperoxide reductase activity" |
| 17 | + - added `term_tracker_item` for issue #31961 |
| 18 | +- Removed remaining GO-internal references to GO:0008785. |
| 19 | + - updated GO:0009321 comment to point to GO:0102039 |
| 20 | + - removed an unrelated stale comment on GO:0070937 that still referenced GO:0008785 |
| 21 | + |
| 22 | +Rationale |
| 23 | + |
| 24 | +The issue rationale is sound: GO:0008785 is an over-specific substrate-level molecular function term, while GO:0102039 already captures the NADH-dependent peroxiredoxin/alkylhydroperoxide reductase activity and carries the EC/RHEA/MetaCyc cross-references. |
| 25 | + |
| 26 | +I validated the two PMIDs cited in the issue context: |
| 27 | + |
| 28 | +- PMID:11717276, "Alkyl hydroperoxide reductase is the primary scavenger of endogenous hydrogen peroxide in Escherichia coli." |
| 29 | +- PMID:21674802, "Proteomics of the oxidative stress response induced by hydrogen peroxide and paraquat reveals a novel AhpC-like protein in Pseudomonas aeruginosa." |
| 30 | + |
| 31 | +Both support annotation to the broader NADH-dependent peroxiredoxin activity term rather than retaining GO:0008785 as a distinct substrate-specific activity. |
| 32 | + |
| 33 | +Validation and research notes |
| 34 | + |
| 35 | +- Pre-validation: `cd src/ontology && make travis_build` passed before edits. |
| 36 | +- Post-validation: `cd src/ontology && make travis_build` passed after edits. |
| 37 | +- PMID validation: performed with `linkml-reference-validator cache reference ...` |
| 38 | +- Research notes captured in `RESEARCH.md` (not committed). |
| 39 | +- I attempted to use `runoak` for annotation/usages lookup per the obsoletion workflow, but the local environment has an oaklib/linkml import error. I therefore relied on the annotation counts given in the issue context and separately validated the cited PMIDs. |
| 40 | + |
| 41 | +Checklist |
| 42 | + |
| 43 | +- [x] PLAN: The issue and context were analyzed and the requested obsoletion/replacement path was clear. |
| 44 | +- [x] PRE-VALIDATION: Current ontology state validated before edits (`make travis_build`). |
| 45 | +- [x] RESEARCH: Annotation-supporting PMIDs reviewed and summarized in `RESEARCH.md`. |
| 46 | +- [x] TERM-SEARCH: Relevant GO terms searched in `src/ontology/go-edit.obo` with `obo-grep.pl`/`grep`. |
| 47 | +- [ ] DESIGN-PATTERNS: N/A for this obsoletion; no new logical definitions or compositional term design added. |
| 48 | +- [x] EDITS: Used checkout/checkin workflow via `obo-checkout.pl` and `obo-checkin.pl` with edits staged through `terms/`. |
| 49 | +- [x] RELATIONSHIPS: Obsolete term stripped of active axioms; remaining internal references rewired appropriately. |
| 50 | + - [x] logical definitions are appropriate, and are not over-specified, and conform to DESIGN_PATTERNS.md doc (N/A; none added) |
| 51 | + - [x] relationships conform to other similar terms in the ontology |
| 52 | + - [x] is_a is not over-asserted |
| 53 | + - [x] is_a, part_of, and other relationships specified appropriately |
| 54 | +- [x] SPECIALIZED-EDITS: |
| 55 | + - [x] /term-obsoletion skill used |
| 56 | + - [x] /reaction skill consulted (catalytic activity / EC-RHEA context) |
| 57 | + - [ ] /chemical-entity skill: N/A |
| 58 | + - [ ] /taxon-constraint skill: N/A |
| 59 | +- [x] METADATA: Obsolete-term metadata and replacement metadata updated appropriately. |
| 60 | +- [x] AUTOMATED-VALIDATION: `make travis_build` passed after changes. |
| 61 | +- [x] REFERENCE-VALIDATION: PMIDs introduced in the issue context and research notes were validated. |
| 62 | +- [x] CHANGES-COMMITTED |
| 63 | + - [x] RELEVANT-FILES: committed only `src/ontology/go-edit.obo` |
| 64 | + - [x] ACCURACY: changes align with the issue rationale and validated literature context |
| 65 | + - [x] ISSUE-ALIGNMENT: changes form a coherent direct-replacement obsoletion |
| 66 | + - [ ] PR is created or amended: N/A here; handled by the evaluation harness |
| 67 | + - [x] Communicate high level summary of changes on original issue(s), and any requests for further info |
| 68 | + - [x] Communicated on PR detailed description of changes made, and rationale |
| 69 | + |
| 70 | +--- |
| 71 | +🤖 **Generated by pi agent** |
| 72 | +- Runtime: `pi` |
| 73 | +- Model: `openai/gpt-5.4` |
| 74 | +- Agent config: `ai4curation/go-ontology-agent-config@v9:.` |
| 75 | +- Iteration: `2` |
| 76 | +- Run: [View workflow run](https://github.com/ai4curation/eval-ont-agent-go/actions/runs/25614306977) |
0 commit comments