Skip to content

Commit 0bfce80

Browse files
traces(31961/openai/gpt-5.4): run 25614306977
1 parent 2e987fe commit 0bfce80

5 files changed

Lines changed: 3547 additions & 0 deletions

File tree

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
Obsoleted GO:0008785 and set GO:0102039 (NADH-dependent peroxiredoxin activity) as the replacement in PR #<NN>.
2+
3+
I also updated the remaining internal reference from GO:0009321 to point to GO:0102039 and removed an unrelated stale comment that still mentioned GO:0008785, so there are no remaining GO-internal references to the obsolete term.
4+
5+
I validated the two annotation PMIDs mentioned in the issue (PMID:11717276 and PMID:21674802); both are consistent with annotation to the broader NADH-dependent peroxiredoxin activity term rather than retaining a separate substrate-specific GO:0008785 term.
6+
7+
---
8+
🤖 **Generated by pi agent**
9+
- Runtime: `pi`
10+
- Model: `openai/gpt-5.4`
11+
- Agent config: `ai4curation/go-ontology-agent-config@v9:.`
12+
- Iteration: `2`
13+
- Run: [View workflow run](https://github.com/ai4curation/eval-ont-agent-go/actions/runs/25614306977)

traces/25614306977/PR_COMMENTS.md

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
Summary
2+
3+
This PR obsoletes GO:0008785 "alkyl hydroperoxide reductase activity" and replaces it with GO:0102039 "NADH-dependent peroxiredoxin activity", as requested in issue #31961.
4+
5+
Changes made
6+
7+
- Obsoleted GO:0008785.
8+
- name -> "obsolete alkyl hydroperoxide reductase activity"
9+
- definition -> prefixed with "OBSOLETE."
10+
- removed active classification
11+
- added obsoletion comment
12+
- added `is_obsolete: true`
13+
- added `replaced_by: GO:0102039`
14+
- added `term_tracker_item` for issue #31961
15+
- Updated GO:0102039.
16+
- transferred the original GO:0008785 label as an EXACT synonym: "alkyl hydroperoxide reductase activity"
17+
- added `term_tracker_item` for issue #31961
18+
- Removed remaining GO-internal references to GO:0008785.
19+
- updated GO:0009321 comment to point to GO:0102039
20+
- removed an unrelated stale comment on GO:0070937 that still referenced GO:0008785
21+
22+
Rationale
23+
24+
The issue rationale is sound: GO:0008785 is an over-specific substrate-level molecular function term, while GO:0102039 already captures the NADH-dependent peroxiredoxin/alkylhydroperoxide reductase activity and carries the EC/RHEA/MetaCyc cross-references.
25+
26+
I validated the two PMIDs cited in the issue context:
27+
28+
- PMID:11717276, "Alkyl hydroperoxide reductase is the primary scavenger of endogenous hydrogen peroxide in Escherichia coli."
29+
- PMID:21674802, "Proteomics of the oxidative stress response induced by hydrogen peroxide and paraquat reveals a novel AhpC-like protein in Pseudomonas aeruginosa."
30+
31+
Both support annotation to the broader NADH-dependent peroxiredoxin activity term rather than retaining GO:0008785 as a distinct substrate-specific activity.
32+
33+
Validation and research notes
34+
35+
- Pre-validation: `cd src/ontology && make travis_build` passed before edits.
36+
- Post-validation: `cd src/ontology && make travis_build` passed after edits.
37+
- PMID validation: performed with `linkml-reference-validator cache reference ...`
38+
- Research notes captured in `RESEARCH.md` (not committed).
39+
- I attempted to use `runoak` for annotation/usages lookup per the obsoletion workflow, but the local environment has an oaklib/linkml import error. I therefore relied on the annotation counts given in the issue context and separately validated the cited PMIDs.
40+
41+
Checklist
42+
43+
- [x] PLAN: The issue and context were analyzed and the requested obsoletion/replacement path was clear.
44+
- [x] PRE-VALIDATION: Current ontology state validated before edits (`make travis_build`).
45+
- [x] RESEARCH: Annotation-supporting PMIDs reviewed and summarized in `RESEARCH.md`.
46+
- [x] TERM-SEARCH: Relevant GO terms searched in `src/ontology/go-edit.obo` with `obo-grep.pl`/`grep`.
47+
- [ ] DESIGN-PATTERNS: N/A for this obsoletion; no new logical definitions or compositional term design added.
48+
- [x] EDITS: Used checkout/checkin workflow via `obo-checkout.pl` and `obo-checkin.pl` with edits staged through `terms/`.
49+
- [x] RELATIONSHIPS: Obsolete term stripped of active axioms; remaining internal references rewired appropriately.
50+
- [x] logical definitions are appropriate, and are not over-specified, and conform to DESIGN_PATTERNS.md doc (N/A; none added)
51+
- [x] relationships conform to other similar terms in the ontology
52+
- [x] is_a is not over-asserted
53+
- [x] is_a, part_of, and other relationships specified appropriately
54+
- [x] SPECIALIZED-EDITS:
55+
- [x] /term-obsoletion skill used
56+
- [x] /reaction skill consulted (catalytic activity / EC-RHEA context)
57+
- [ ] /chemical-entity skill: N/A
58+
- [ ] /taxon-constraint skill: N/A
59+
- [x] METADATA: Obsolete-term metadata and replacement metadata updated appropriately.
60+
- [x] AUTOMATED-VALIDATION: `make travis_build` passed after changes.
61+
- [x] REFERENCE-VALIDATION: PMIDs introduced in the issue context and research notes were validated.
62+
- [x] CHANGES-COMMITTED
63+
- [x] RELEVANT-FILES: committed only `src/ontology/go-edit.obo`
64+
- [x] ACCURACY: changes align with the issue rationale and validated literature context
65+
- [x] ISSUE-ALIGNMENT: changes form a coherent direct-replacement obsoletion
66+
- [ ] PR is created or amended: N/A here; handled by the evaluation harness
67+
- [x] Communicate high level summary of changes on original issue(s), and any requests for further info
68+
- [x] Communicated on PR detailed description of changes made, and rationale
69+
70+
---
71+
🤖 **Generated by pi agent**
72+
- Runtime: `pi`
73+
- Model: `openai/gpt-5.4`
74+
- Agent config: `ai4curation/go-ontology-agent-config@v9:.`
75+
- Iteration: `2`
76+
- Run: [View workflow run](https://github.com/ai4curation/eval-ont-agent-go/actions/runs/25614306977)
Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
{
2+
"body": "This entry has no EC/RHEA/MetaCyc/KEGG xref:\n\nid: GO:0008785\nname: alkyl hydroperoxide reductase activity\nnamespace: molecular_function\ndef: \"Catalysis of the reaction: octane hydroperoxide + NADH + H+ = H2O + NAD+ + 1-octanol.\" [GOC:curators]\nis_a: GO:0016668 ! oxidoreductase activity, acting on a sulfur group of donors, NAD(P) as acceptor\nproperty_value: term_tracker_item \"https://github.com/geneontology/go-ontology/issues/28261\" xsd:anyURI\nproperty_value: term_tracker_item \"https://github.com/geneontology/go-ontology/issues/28340\" xsd:anyURI\n\nDespite the generic-sounding name, this is actually a substrate-specific version of the following term (and note that \"alkyl hydroperoxide reductase\" is listed as synonym of EC 1.11.1.26 at Expasy):\n\nid: GO:0102039\nname: NADH-dependent peroxiredoxin activity\nnamespace: molecular_function\ndef: \"Catalysis of the reaction: a hydroperoxide + H+ + NADH = an alcohol + H2O + NAD+.\" [GOC:pz, PMID:12517450, RHEA:62628]\nsynonym: \"alkylhydroperoxide reductase activity\" EXACT []\nxref: EC:1.11.1.26 {source=\"skos:exactMatch\"}\nxref: MetaCyc:R4-RXN\nxref: RHEA:62628 {source=\"skos:exactMatch\"}\nis_a: GO:0051920 ! peroxiredoxin activity\nproperty_value: term_tracker_item \"https://github.com/geneontology/go-ontology/issues/30193\" xsd:anyURI\n\n\nSo, GO:0008785 should be obsoleted and replaced with GO:0102039.\n\nThere are only 3 annotations (2 EXP) to GO:0008785 alkyl hydroperoxide reductase activity:\n- E.coli AhpF from PMID:11717276 by EcoliWiki\n- Pseudomonas PA3529 from PMID:21674802 by PseudoCAP\n\n\n",
3+
"comments": [
4+
{
5+
"id": "IC_kwDOAkAHws8AAAABAyI_4Q",
6+
"author": {
7+
"login": "raymond91125"
8+
},
9+
"authorAssociation": "MEMBER",
10+
"body": "Dear all, \n\nThe proposal has been made to obsolete GO:0008785 alkyl hydroperoxide reductase activity.\n\n* The reason for obsoletion is that it is more specific than the specificity of any known gene product.\n\nExperimental annotations\nEcoliWiki 1\nPseudoCAP 1\n\nNo InterPro2GO/UniRule/UniProtKW mappings.\n\nAnnotations can be viewed here: \nhttps://github.com/geneontology/go-annotation/issues/6396\n\nThis term is being replaced by GO:0102039 NADH-dependent peroxiredoxin activity\n\nAny comments can be added to the issue: https://github.com/geneontology/go-ontology/issues/31961\n\n\nThanks, \n",
11+
"createdAt": "2026-04-29T21:11:56Z",
12+
"includesCreatedEdit": false,
13+
"isMinimized": false,
14+
"minimizedReason": "",
15+
"reactionGroups": [],
16+
"url": "https://github.com/geneontology/go-ontology/issues/31961#issuecomment-4347543521",
17+
"viewerDidAuthor": false
18+
},
19+
{
20+
"id": "IC_kwDOAkAHws8AAAABAyJLkg",
21+
"author": {
22+
"login": "raymond91125"
23+
},
24+
"authorAssociation": "MEMBER",
25+
"body": "@dragon-ai-agent please obsolete GO:0008785 alkyl hydroperoxide reductase activity.",
26+
"createdAt": "2026-04-29T21:12:29Z",
27+
"includesCreatedEdit": false,
28+
"isMinimized": false,
29+
"minimizedReason": "",
30+
"reactionGroups": [
31+
{
32+
"content": "EYES",
33+
"users": {
34+
"totalCount": 1
35+
}
36+
}
37+
],
38+
"url": "https://github.com/geneontology/go-ontology/issues/31961#issuecomment-4347546514",
39+
"viewerDidAuthor": false
40+
},
41+
{
42+
"id": "IC_kwDOAkAHws8AAAABAyJU3g",
43+
"author": {
44+
"login": "dragon-ai-agent"
45+
},
46+
"authorAssociation": "MEMBER",
47+
"body": "🤖 Working on it...\n\nFollow along: [View workflow run](https://github.com/geneontology/go-ontology/actions/runs/25134164454)\n\n*— @dragon-ai-agent*",
48+
"createdAt": "2026-04-29T21:12:54Z",
49+
"includesCreatedEdit": false,
50+
"isMinimized": false,
51+
"minimizedReason": "",
52+
"reactionGroups": [],
53+
"url": "https://github.com/geneontology/go-ontology/issues/31961#issuecomment-4347548894",
54+
"viewerDidAuthor": true
55+
}
56+
],
57+
"title": "obsolete GO:0008785 alkyl hydroperoxide reductase activity",
58+
"url": "https://github.com/geneontology/go-ontology/issues/31961"
59+
}

0 commit comments

Comments
 (0)