Skip to content

Commit 72db7d5

Browse files
traces(31961/gpt-5.4): run 25592435780
1 parent 67b86b6 commit 72db7d5

5 files changed

Lines changed: 214 additions & 0 deletions

File tree

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
Obsoleted `GO:0008785` and replaced it with `GO:0102039` in PR #<NN>.
2+
3+
I also updated the related `GO:0009321` comment to point to `GO:0102039` and removed one stale copied comment elsewhere that still referenced `GO:0008785`, so the ontology no longer points at the obsolete MF term.
4+
5+
Local validation passed with `cd src/ontology && make travis_build`.
6+
7+
---
8+
🤖 **Generated by codex agent**
9+
- Runtime: `codex`
10+
- Model: `gpt-5.4`
11+
- Agent config: `ai4curation/go-ontology-agent-config@v8-noskills:.`
12+
- Iteration: `1`
13+
- Run: [View workflow run](https://github.com/ai4curation/eval-ont-agent-go/actions/runs/25592435780)

traces/25592435780/PR_COMMENTS.md

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
Obsoleted `GO:0008785` (`alkyl hydroperoxide reductase activity`) and replaced it with `GO:0102039` (`NADH-dependent peroxiredoxin activity`) as requested in issue #31961.
2+
3+
Changes made:
4+
- Marked `GO:0008785` obsolete, prefixed the definition with `OBSOLETE.`, added an obsoletion comment, added a tracker link to issue `#31961`, and set `replaced_by: GO:0102039`.
5+
- Updated `GO:0009321` (`alkyl hydroperoxide reductase complex`) so its see-also comment now points to `GO:0102039`.
6+
- Removed an unrelated stale copied comment on `GO:0070937` that still referenced `GO:0008785`, preventing an obsolete-term reference from remaining in the ontology.
7+
8+
Rationale:
9+
- The issue discussion indicates `GO:0008785` is an over-specific substrate instance of the broader, already-curated `GO:0102039`, and the requested migration target is exact.
10+
- Cleaning the remaining ontology comments avoids leaving dangling references to an obsolete MF term.
11+
12+
Validation:
13+
- Pre-validation: `cd src/ontology && make travis_build`
14+
- Post-edit validation: `cd src/ontology && make travis_build`
15+
- Result: passed, including `replacedby-obsolete-violation.sparql`, `replacedby-namespace-violation.sparql`, and `obsolete-reference-violation.sparql`
16+
17+
Checklist:
18+
- [x] PLAN: Issue and comments reviewed; intent was clear.
19+
- [x] PRE-VALIDATION: `make travis_build` passed before edits.
20+
- [x] RESEARCH: N/A, no new references introduced.
21+
- [x] TERM-SEARCH: Checked `GO:0008785`, `GO:0102039`, and ontology-wide references to `GO:0008785`.
22+
- [x] DESIGN-PATTERNS: N/A for a straightforward obsoletion/replacement.
23+
- [x] EDITS: Used checkout/checkin workflow for edited GO terms.
24+
- [x] RELATIONSHIPS: Obsoletion used `replaced_by: GO:0102039`; no new logical axioms added.
25+
- [x] SPECIALIZED-EDITS: Obsoletion cleanup completed, including removal/update of stale references to the obsolete term.
26+
- [x] METADATA: Preserved existing metadata and added the new `term_tracker_item` for issue `#31961`.
27+
- [x] AUTOMATED-VALIDATION: `make travis_build` passed after changes.
28+
- [x] REFERENCE-VALIDATION: No new PMIDs or other references introduced.
29+
- [x] CHANGES-COMMITTED: Committed locally.
30+
31+
---
32+
🤖 **Generated by codex agent**
33+
- Runtime: `codex`
34+
- Model: `gpt-5.4`
35+
- Agent config: `ai4curation/go-ontology-agent-config@v8-noskills:.`
36+
- Iteration: `1`
37+
- Run: [View workflow run](https://github.com/ai4curation/eval-ont-agent-go/actions/runs/25592435780)
Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
{
2+
"body": "This entry has no EC/RHEA/MetaCyc/KEGG xref:\n\nid: GO:0008785\nname: alkyl hydroperoxide reductase activity\nnamespace: molecular_function\ndef: \"Catalysis of the reaction: octane hydroperoxide + NADH + H+ = H2O + NAD+ + 1-octanol.\" [GOC:curators]\nis_a: GO:0016668 ! oxidoreductase activity, acting on a sulfur group of donors, NAD(P) as acceptor\nproperty_value: term_tracker_item \"https://github.com/geneontology/go-ontology/issues/28261\" xsd:anyURI\nproperty_value: term_tracker_item \"https://github.com/geneontology/go-ontology/issues/28340\" xsd:anyURI\n\nDespite the generic-sounding name, this is actually a substrate-specific version of the following term (and note that \"alkyl hydroperoxide reductase\" is listed as synonym of EC 1.11.1.26 at Expasy):\n\nid: GO:0102039\nname: NADH-dependent peroxiredoxin activity\nnamespace: molecular_function\ndef: \"Catalysis of the reaction: a hydroperoxide + H+ + NADH = an alcohol + H2O + NAD+.\" [GOC:pz, PMID:12517450, RHEA:62628]\nsynonym: \"alkylhydroperoxide reductase activity\" EXACT []\nxref: EC:1.11.1.26 {source=\"skos:exactMatch\"}\nxref: MetaCyc:R4-RXN\nxref: RHEA:62628 {source=\"skos:exactMatch\"}\nis_a: GO:0051920 ! peroxiredoxin activity\nproperty_value: term_tracker_item \"https://github.com/geneontology/go-ontology/issues/30193\" xsd:anyURI\n\n\nSo, GO:0008785 should be obsoleted and replaced with GO:0102039.\n\nThere are only 3 annotations (2 EXP) to GO:0008785 alkyl hydroperoxide reductase activity:\n- E.coli AhpF from PMID:11717276 by EcoliWiki\n- Pseudomonas PA3529 from PMID:21674802 by PseudoCAP\n\n\n",
3+
"comments": [
4+
{
5+
"id": "IC_kwDOAkAHws8AAAABAyI_4Q",
6+
"author": {
7+
"login": "raymond91125"
8+
},
9+
"authorAssociation": "MEMBER",
10+
"body": "Dear all, \n\nThe proposal has been made to obsolete GO:0008785 alkyl hydroperoxide reductase activity.\n\n* The reason for obsoletion is that it is more specific than the specificity of any known gene product.\n\nExperimental annotations\nEcoliWiki 1\nPseudoCAP 1\n\nNo InterPro2GO/UniRule/UniProtKW mappings.\n\nAnnotations can be viewed here: \nhttps://github.com/geneontology/go-annotation/issues/6396\n\nThis term is being replaced by GO:0102039 NADH-dependent peroxiredoxin activity\n\nAny comments can be added to the issue: https://github.com/geneontology/go-ontology/issues/31961\n\n\nThanks, \n",
11+
"createdAt": "2026-04-29T21:11:56Z",
12+
"includesCreatedEdit": false,
13+
"isMinimized": false,
14+
"minimizedReason": "",
15+
"reactionGroups": [],
16+
"url": "https://github.com/geneontology/go-ontology/issues/31961#issuecomment-4347543521",
17+
"viewerDidAuthor": false
18+
},
19+
{
20+
"id": "IC_kwDOAkAHws8AAAABAyJLkg",
21+
"author": {
22+
"login": "raymond91125"
23+
},
24+
"authorAssociation": "MEMBER",
25+
"body": "@dragon-ai-agent please obsolete GO:0008785 alkyl hydroperoxide reductase activity.",
26+
"createdAt": "2026-04-29T21:12:29Z",
27+
"includesCreatedEdit": false,
28+
"isMinimized": false,
29+
"minimizedReason": "",
30+
"reactionGroups": [
31+
{
32+
"content": "EYES",
33+
"users": {
34+
"totalCount": 1
35+
}
36+
}
37+
],
38+
"url": "https://github.com/geneontology/go-ontology/issues/31961#issuecomment-4347546514",
39+
"viewerDidAuthor": false
40+
},
41+
{
42+
"id": "IC_kwDOAkAHws8AAAABAyJU3g",
43+
"author": {
44+
"login": "dragon-ai-agent"
45+
},
46+
"authorAssociation": "MEMBER",
47+
"body": "🤖 Working on it...\n\nFollow along: [View workflow run](https://github.com/geneontology/go-ontology/actions/runs/25134164454)\n\n*— @dragon-ai-agent*",
48+
"createdAt": "2026-04-29T21:12:54Z",
49+
"includesCreatedEdit": false,
50+
"isMinimized": false,
51+
"minimizedReason": "",
52+
"reactionGroups": [],
53+
"url": "https://github.com/geneontology/go-ontology/issues/31961#issuecomment-4347548894",
54+
"viewerDidAuthor": true
55+
}
56+
],
57+
"title": "obsolete GO:0008785 alkyl hydroperoxide reductase activity",
58+
"url": "https://github.com/geneontology/go-ontology/issues/31961"
59+
}

0 commit comments

Comments
 (0)