Skip to content

Commit 4094de8

Browse files
committed
⬆️ dill: require at least 0.3.6
`PickledData` pickles with `recurse=True`, which `dill` grew in 0.3.0, and parser round-trips only survive from 0.3.6. The requirement was inherited unpinned from `aiida-shell`, which had no job resolving its dependencies downwards, so the minimum-requirements job resolved `dill==0.2` and every test that pickles a parser failed. Bisected against the parser tests: 0.3.0 through 0.3.4 accept the keyword but cannot unpickle what they wrote, 0.3.6 is the first that round-trips. The upper bound keeps the currently used 0.4.1 in range.
1 parent 84a37c1 commit 4094de8

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

environment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ dependencies:
1212
- circus~=0.19.0
1313
- click-spinner~=0.1.8
1414
- click<8.3,>=8.1.0
15-
- dill
15+
- dill<1,>=0.3.6
1616
- disk-objectstore~=1.5.0
1717
- docstring_parser
1818
- python-graphviz~=0.19

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ dependencies = [
3535
'circus~=0.19.0',
3636
'click-spinner~=0.1.8',
3737
'click>=8.1.0,<8.3',
38-
'dill',
38+
'dill>=0.3.6,<1',
3939
'disk-objectstore~=1.5.0',
4040
'docstring-parser',
4141
'graphviz~=0.19',

uv.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)