Skip to content

Commit 7ce2834

Browse files
Bud-MacaulayBud-Macaulay
committed
eslint fixes
1 parent 7ccfc39 commit 7ce2834

13 files changed

Lines changed: 47 additions & 96 deletions

File tree

‎check-prefix.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,10 @@ function walkDir(dir) {
6868
}
6969

7070
// run the check from src
71+
// eslint-disable-next-line no-undef
7172
walkDir(path.join(process.cwd(), "src"));
7273

7374
// summary
74-
console.log("\ae: tailwind prefix check completed!");
75+
console.log("ae: tailwind prefix check completed!");
7576
console.log(`Files scanned: ${filesScanned}`);
7677
console.log(`Warnings found: ${warningsFound}`);

‎package-lock.json‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/AiidaExplorer/GroupsViewer/index.jsx‎

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
import React, { useEffect, useState, useCallback, useMemo } from "react";
22

33
import { fetchGroups, fetchFromQueryBuilder } from "../api";
4-
54
import TypeCheckboxTree from "./TypeCheckboxTree";
65
import { getFlattenedNodeTypes, aiidaTypes, buildQuery } from "./utils";
7-
86
import DataTable from "../components/DataTable";
97
import ErrorDisplay from "../components/Error";
108
import Spinner from "../components/Spinner";
@@ -21,14 +19,7 @@ const columnLabels = {
2119
};
2220

2321
// desired column order
24-
export const columnOrder = [
25-
"Unique ID",
26-
"Label",
27-
"Type",
28-
"Created",
29-
"Modified",
30-
"",
31-
];
22+
const columnOrder = ["Unique ID", "Label", "Type", "Created", "Modified", ""];
3223

3324
// format a single value based on label and screen size
3425
function formatValue(label, value, isSmallScreen = false) {
@@ -46,11 +37,12 @@ function formatValue(label, value, isSmallScreen = false) {
4637
return value;
4738

4839
case "Created":
49-
case "Modified":
40+
case "Modified": {
5041
const date = new Date(value);
5142
return isSmallScreen
5243
? date.toISOString().split("T")[0]
5344
: date.toLocaleString();
45+
}
5446

5547
case "Unique ID":
5648
if (isSmallScreen && typeof value === "string")

‎src/AiidaExplorer/VisualiserPane/Rich/CalcJobVisualiser.jsx‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
import React, { useState } from "react";
2-
import { JsonView, defaultStyles } from "react-json-view-lite";
3-
import "react-json-view-lite/dist/index.css";
42

53
import DataTable from "../../components/DataTable";
6-
74
import {
85
ClipBoardIcon,
96
ClipboardCopyIcon,
@@ -13,8 +10,6 @@ import {
1310
import Overlay from "../../components/Overlay";
1411

1512
function FileTable({ title, dataArray = [], onView }) {
16-
if (!Array.isArray(dataArray) || dataArray.length === 0) return null;
17-
1813
const columns = ["File", "Download", "View"];
1914
const rows = dataArray.map((file) => ({
2015
File: file.name,
@@ -58,17 +53,10 @@ function FileTable({ title, dataArray = [], onView }) {
5853
}
5954

6055
export default function CalcJobVisualiser({ nodeData = {} }) {
61-
const [copiedIndex, setCopiedIndex] = useState(null);
6256
const [previewContent, setPreviewContent] = useState(null);
6357
const [previewName, setPreviewName] = useState(null);
6458
const [isOpen, setIsOpen] = useState(false);
6559

66-
const copyToClipboard = (data, index) => {
67-
navigator.clipboard.writeText(JSON.stringify(data, null, 2));
68-
setCopiedIndex(index);
69-
setTimeout(() => setCopiedIndex(null), 700);
70-
};
71-
7260
const handleViewFile = async (name, url) => {
7361
try {
7462
const res = await fetch(url);

‎src/AiidaExplorer/VisualiserPane/Rich/KpointsDataVisualiser/BZVis.jsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import React, { useState, useEffect, useRef } from "react";
21
import { createBZVisualizer } from "brillouinzone-visualizer";
3-
import useContainerBucket from "../../../hooks/useContainerBucket";
2+
import React, { useState, useEffect, useRef } from "react";
43

54
import BZControls from "./BZControls";
5+
import useContainerBucket from "../../../hooks/useContainerBucket";
66

77
export default function BZVisualizer({ data }) {
88
const containerRef = useRef(null);

‎src/AiidaExplorer/VisualiserPane/Rich/KpointsDataVisualiser/index.jsx‎

Lines changed: 23 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,43 +1,38 @@
1-
import React, { useEffect, useRef, useMemo } from "react";
2-
3-
import CardContainer from "../../../components/CardContainer";
4-
import DataTable from "../../../components/DataTable";
1+
import React, { useMemo } from "react";
52

63
import BZVisualizer from "./BZVis";
7-
84
import { RoundVals, reciprocalLattice, Columns } from "./utils";
5+
import CardContainer from "../../../components/CardContainer";
6+
import DataTable from "../../../components/DataTable";
97

108
// TODO - build a KPOINT converter that spits out VASP/QE formats
119
// TODO - Dont render missing tables / better fallbacks
1210
// KpointsDataVisualiser.js
1311
export default function KpointsDataVisualiser({ nodeData = {} }) {
14-
const attributes = nodeData.attributes || {};
15-
const derivedProperties = nodeData.derived_properties || {};
16-
17-
// check if there is a k-path
18-
let path = null;
19-
if (attributes?.labels && attributes?.label_numbers) {
20-
path = attributes.labels.join(" → ");
21-
if (path.length > 20) {
22-
path = path.slice(0, 17) + "...";
23-
}
24-
}
25-
26-
const hasData = useMemo(
27-
() => !!attributes?.cell || !!derivedProperties,
28-
[attributes, derivedProperties]
12+
// Memoize attributes and derived_properties
13+
const attributes = useMemo(
14+
() => nodeData.attributes || {},
15+
[nodeData.attributes]
2916
);
30-
if (!hasData) return <div>No attributes available</div>;
17+
const derivedProperties = useMemo(
18+
() => nodeData.derived_properties || {},
19+
[nodeData.derived_properties]
20+
);
21+
22+
const hasData = !!attributes?.cell || !!derivedProperties;
23+
24+
// k-path string
25+
const path =
26+
attributes?.labels && attributes?.label_numbers
27+
? attributes.labels.join(" → ").slice(0, 20)
28+
: null;
3129

3230
// ----- Reciprocal lattice -----
3331
const [b1, b2, b3] = useMemo(() => {
3432
if (!attributes.cell) return [null, null, null];
3533
return reciprocalLattice(attributes.cell);
3634
}, [attributes.cell]);
3735

38-
if (attributes?.labelled_kpoints_abs) {
39-
}
40-
4136
// ----- Memoized BZ data -----
4237
const bzData = useMemo(() => {
4338
if (!attributes.cell) return null;
@@ -49,7 +44,7 @@ export default function KpointsDataVisualiser({ nodeData = {} }) {
4944
kpoints: derivedProperties.labelled_kpoints_abs,
5045
path: derivedProperties.labelled_path,
5146
};
52-
}, [b1, b2, b3, derivedProperties]);
47+
}, [b1, b2, b3, derivedProperties, attributes.cell]);
5348

5449
// ----- Reciprocal lattice table -----
5550
const recipData = useMemo(() => {
@@ -128,7 +123,7 @@ export default function KpointsDataVisualiser({ nodeData = {} }) {
128123
[derivedProperties.explicit_kpoints_rel]
129124
);
130125

131-
// Table configuration array for mapping
126+
// ----- Tables -----
132127
const tables = useMemo(
133128
() => [
134129
{
@@ -157,6 +152,8 @@ export default function KpointsDataVisualiser({ nodeData = {} }) {
157152
[recipData, cellData, meshOffsetRows, pbcData, kpointData, kpointDataR]
158153
);
159154

155+
if (!hasData) return <div>No attributes available</div>;
156+
160157
return (
161158
<div className="ae:w-full ae:mx-auto ae:p-4 ae:space-y-2">
162159
{/* Brillouin Zone visualizer card */}
@@ -172,7 +169,6 @@ export default function KpointsDataVisualiser({ nodeData = {} }) {
172169
</CardContainer>
173170
)}
174171

175-
{/* Tables in cards */}
176172
<div className="ae:@container">
177173
{/* <xl=1col, >xl=2col */}
178174
<div className="ae:grid ae:grid-cols-1 ae:@xl:grid-cols-2">

‎src/AiidaExplorer/VisualiserPane/Rich/StructureDataVisualiser/index.jsx‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,18 @@
11
import StructureVisualizer from "mc-react-structure-visualizer";
22
import { useEffect, useState, useCallback } from "react";
33

4-
import CardContainer from "../../../components/CardContainer";
5-
6-
import ErrorDisplay from "../../../components/Error";
7-
import Spinner from "../../../components/Spinner";
8-
94
import { StructDownloadButton } from "./StructDownloadButton";
10-
115
import {
126
formatLattice,
137
getVol,
148
formatChemicalFormula,
159
calculateDensity,
1610
} from "./utils";
11+
import CardContainer from "../../../components/CardContainer";
12+
import ErrorDisplay from "../../../components/Error";
13+
import Spinner from "../../../components/Spinner";
14+
15+
1716

1817
// StructureData has the 'derivedProps' key, cifData does not and we have to handle such case.
1918
// TODO - add the full js method for multiple file types here. it seems quite cheap and probably a good use case

‎src/AiidaExplorer/VisualiserPane/Rich/StructureDataVisualiser/utils.jsx‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -30,20 +30,6 @@ export function formatChemicalFormula(formula) {
3030
return v;
3131
});
3232
}
33-
const overlineStyle = {
34-
display: "inline-block",
35-
position: "relative",
36-
};
37-
38-
const overlineAdjustmentStyle = {
39-
position: "absolute",
40-
top: "0.15em",
41-
left: 0,
42-
right: 0,
43-
borderTop: "0.1em solid black",
44-
height: 0,
45-
zIndex: 1,
46-
};
4733

4834
export function countNumberOfAtoms(hillFormula) {
4935
// split on capital letters to get element+number strings

‎src/AiidaExplorer/VisualiserPane/Rich/UpfDataVisualiser.jsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ export default function UpfDataVisualiser({ nodeData }) {
158158

159159
if (!upfData) return null;
160160

161-
const { header, radial_grid } = upfData;
161+
const { header } = upfData;
162162

163163
const commonLegend = {
164164
x: 0.97,
@@ -194,7 +194,7 @@ export default function UpfDataVisualiser({ nodeData }) {
194194
{/* container that constrains width and uses box-sizing */}
195195
<CardContainer
196196
header="Orbital radial functions"
197-
className="ae:!px-1.5 ae:!py-2"
197+
className="ae:px-1.5! ae:py-2!"
198198
childrenClassName="ae:!p-0"
199199
>
200200
<SimplePlot
@@ -215,7 +215,7 @@ export default function UpfDataVisualiser({ nodeData }) {
215215

216216
<CardContainer
217217
header="Beta projectors"
218-
className="ae:!px-1.5 ae:!py-2"
218+
className="ae:px-1.5! ae:py-2!"
219219
childrenClassName="ae:!p-0"
220220
>
221221
<SimplePlot
@@ -234,7 +234,7 @@ export default function UpfDataVisualiser({ nodeData }) {
234234

235235
<CardContainer
236236
header="Charge densities"
237-
className="ae:!px-1.5 ae:!py-2"
237+
className="ae:px-1.5! ae:py-2!"
238238
childrenClassName="ae:!p-0"
239239
>
240240
<SimplePlot

‎src/AiidaExplorer/VisualiserPane/index.jsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import { useState, useEffect } from "react";
33
import FormattedMetaData from "./FormattedMetaData";
44
import RawDataVisualiser from "./RawDataVisualiser";
55
import BandsDataVisualiser from "./Rich/BandsDataVisualiser";
6+
import CalcJobVisualiser from "./Rich/CalcJobVisualiser";
67
import KpointsDataVisualiser from "./Rich/KpointsDataVisualiser";
78
import StructureDataVisualiser from "./Rich/StructureDataVisualiser";
89
import UpfDataVisualiser from "./Rich/UpfDataVisualiser";
9-
import CalcJobVisualiser from "./Rich/CalcJobVisualiser";
1010

1111
const RICH_TYPES = {
1212
StructureData: StructureDataVisualiser,

0 commit comments

Comments
 (0)