Hyperqueue error in `set_parallelization`

[npaulish]

aiida-wannier90-workflows/src/aiida_wannier90_workflows/utils/workflows/builder/setter.py

Lines 130 to 143 in d0b76c0

	if run_hyperqueue:
	if aiida_hq_installed:
	metadata = get_metadata_hq(
	num_cpus=num_cpus,
	max_wallclock_seconds=max_wallclock_seconds,
	memory_mb=memory_mb,
	queue_name=queue_name,
	account=account,
	)
	else: # aiida-hyperqueue not installed
	raise ModuleNotFoundError(
	"Must install aiida-hyperqueue using AiiDA with hyperqueue"
	)
	else:

Is this really needed in the setter function? It was causing an error in AIidalab where Hyperqueue is used. However, everything works when I just commented this out (aiida-hyperqueue should take care of adapting the metadata if I'm not mistaken).

We found this together with @superstar54
Pinging @jiang-yuha0 @qiaojunfeng

[qiaojunfeng]

If we comment this out, then we won't be able to set e.g. max_wallclock_seconds when using HQ?

[edan-bainglass]

Have a look a #83. Might be related. Not sure what the original issue of @npaulish was.

[edan-bainglass]

Have a look a #83. Might be related. Not sure what the original issue of @npaulish was.

@npaulish if #83 indeed fixed this matter, let's close this issue 🙂