Merge pull request #12 from aiman-mumtaz/issue-ai-sec

Refactor Code

Author: aiman-mumtaz

…n/java/com/aiman/api/ApiApplication.java …com/aiman/api/NafathMockApplication.javabackend/src/main/java/com/aiman/api/ApiApplication.java renamed to backend/src/main/java/com/aiman/api/NafathMockApplication.java backend/src/main/java/com/aiman/api/ApiApplication.java renamed to backend/src/main/java/com/aiman/api/NafathMockApplication.java

@@ -4,10 +4,10 @@
 import org.springframework.boot.autoconfigure.SpringBootApplication;
 
 @SpringBootApplication
-public class ApiApplication {
+public class NafathMockApplication {
 
 	public static void main(String[] args) {
-		SpringApplication.run(ApiApplication.class, args);
+		SpringApplication.run(NafathMockApplication.class, args);
 	}
 
 }

backend/src/main/java/com/aiman/api/controller/NafathController.java

@@ -18,7 +18,6 @@
 import com.aiman.api.service.RiskAssessmentService;
 
 import jakarta.servlet.http.HttpServletRequest;
-import jakarta.validation.Valid;
 
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.PatchMapping;
@@ -58,8 +57,6 @@ public ResponseEntity<?> initiate(@RequestBody InitiateRequest req, HttpServletR
 
     @GetMapping("/status/{id}")
     public ResponseEntity<?> poll (@PathVariable String id) {
-        // String status = nafathService.checkStatus(id);
-        // return ResponseEntity.ok(new NafathResponse(id, null, status));
         try {
             UUID uuid = UUID.fromString(id);
 

backend/src/main/java/com/aiman/api/entity/NafathRequest.java

@@ -30,7 +30,6 @@ public class NafathRequest {
     @Column(name = "updated_at")
     private Timestamp updatedAt;
 
-    // Standard Boilerplate (Guarantees the compiler won't fail)
     public NafathRequest() {}
 
     public UUID getId() { return id; }

frontend/app/page.tsx

@@ -14,7 +14,6 @@ export default function NafathPage() {
   const [aiInsight, setAiInsight] = useState<{ score: number; verdict: string; reason: string } | null>(null);
   const [error, setError] = useState('');
 
-  // 1. Initiate Login with AI Risk Assessment
   const handleStartAuth = async (e: React.FormEvent) => {
     e.preventDefault();
     if (nationalId.length !== 10) return setError("National ID must be 10 digits");
@@ -40,16 +39,13 @@ export default function NafathPage() {
       setAiInsight(data.aiInsight);
       setRequestId(data.nafath.id);
       setRandomCode(data.nafath.randomCode);
-      
-      // Delay slightly to show the "Scanning" animation for UX
       setTimeout(() => setStep('CHALLENGE'), 1500);
     } catch (err) {
       setStep('ERROR');
       setError("Failed to connect to Security Gateway.");
     }
   };
 
-  // 2. Polling for Status Updates
   useEffect(() => {
     let interval: NodeJS.Timeout;
     if (step === 'CHALLENGE' && requestId) {
@@ -70,7 +66,6 @@ export default function NafathPage() {
     return () => clearInterval(interval);
   }, [step, requestId]);
 
-  // 3. Mobile Simulator (PATCH)
   const simulateMobileAppApproval = async () => {
     if (!requestId) return;
     try {
@@ -88,7 +83,6 @@ export default function NafathPage() {
     <div className="min-h-screen bg-[#0a0c10] text-slate-200 flex flex-col items-center justify-center p-6 font-sans">
       <div className="w-full max-w-md">
 
-        {/* Header */}
         <div className="text-center mb-10">
           <div className="inline-flex p-3 rounded-2xl bg-emerald-500/10 mb-4 border border-emerald-500/20">
             <ShieldCheck className="text-emerald-500 w-8 h-8" />
@@ -97,7 +91,6 @@ export default function NafathPage() {
           <p className="text-slate-500 text-sm mt-2">National Single Sign-On Simulation</p>
         </div>
 
-        {/* Step 1: Input */}
         {step === 'IDLE' && (
           <form onSubmit={handleStartAuth} className="space-y-4 animate-in fade-in slide-in-from-bottom-4">
             <div className="space-y-2">
@@ -117,7 +110,6 @@ export default function NafathPage() {
           </form>
         )}
 
-        {/* Step 2: AI Scanning */}
         {step === 'SCANNING' && (
           <div className="bg-slate-900/50 border border-slate-800 rounded-3xl p-10 text-center space-y-6">
             <div className="relative flex justify-center">
@@ -131,10 +123,8 @@ export default function NafathPage() {
           </div>
         )}
 
-        {/* Step 3: Challenge */}
         {step === 'CHALLENGE' && (
           <div className="space-y-6 animate-in zoom-in-95">
-            {/* AI Insights Card */}
             <div className="bg-blue-500/5 border border-blue-500/20 rounded-2xl p-4 flex gap-4 items-start">
               <BrainCircuit className="text-blue-400 shrink-0 mt-1" />
               <div>
@@ -143,7 +133,6 @@ export default function NafathPage() {
               </div>
             </div>
 
-            {/* Nafath Challenge Card */}
             <div className="bg-white rounded-3xl p-8 text-center shadow-2xl overflow-hidden relative">
               <div className="absolute top-0 right-0 p-4 opacity-5">
                  <Smartphone size={120} />
@@ -158,7 +147,6 @@ export default function NafathPage() {
               </div>
             </div>
 
-            {/* Mobile Simulator Panel */}
             <div className="bg-slate-900 rounded-2xl p-4 border border-slate-800">
                <button 
                 onClick={simulateMobileAppApproval}
@@ -179,7 +167,6 @@ export default function NafathPage() {
           </div>
         )}
 
-        {/* Step 4: Success */}
         {step === 'SUCCESS' && (
           <div className="text-center space-y-6 animate-in fade-in scale-95">
             <div className="inline-flex p-6 rounded-full bg-emerald-500/20 text-emerald-500 shadow-[0_0_40px_-10px_rgba(16,185,129,0.3)]">
@@ -196,7 +183,6 @@ export default function NafathPage() {
           </div>
         )}
 
-        {/* Errors */}
         {step === 'ERROR' && (
           <div className="bg-red-500/10 border border-red-500/20 rounded-2xl p-6 text-center space-y-4">
              <AlertTriangle className="mx-auto text-red-500 w-10 h-10" />