TypeError: asyncio.streams.start_server() got multiple values for keyword argument 'ssl'

[senyai]

await server.run(host="127.0.0.1", port=8025, ssl=True)

server.run is annotated with AsyncIOStartServerKwargs kwargs, but actually doesn't allow ssl as a keyword

[senyai]

One more typing mistake here, tuple[str] should at least be tuple[str, ...] or Sequence[str] or custom Protocol

aioftp/src/aioftp/server.py

Line 895 in 226ad64

async def parse_command(self, stream: StreamIO, censor_commands: tuple[str] = ("pass",)) -> tuple[str, str]:

[senyai]

Please, let me make this issue a code review.

aioftp/src/aioftp/server.py

Lines 1164 to 1174 in 226ad64

	@ConnectionConditions(ConnectionConditions.login_required)
	@PathConditions(
	PathConditions.path_must_exists,
	PathConditions.path_must_be_dir,
	)
	@PathPermissions(PathPermissions.readable)
	async def cwd(self, connection: Connection, rest: str | PurePosixPath) -> bool:
	real_path, virtual_path = self.get_paths(connection, rest)
	connection.current_directory = virtual_path
	connection.response("250", "")
	return True

Here PathConditions calls get_paths, PathPermissions calls get_paths and cwd itself calls get_paths. So, three calls for get_paths. I think get_paths should only be called once. For it PathConditions and PathPermissions should be merged and result of get_paths should be passed to the wrapped function.

[senyai]

aioftp/src/aioftp/server.py

Line 220 in 226ad64

async def authenticate(self, user: User, password: str) -> bool:

Authenticate method returns bool, disallowing more informative feedback, for example, returning False when authentication server is unavailable is not right.