Skip to content

How can I enforce CORS despite middlewares? #481

Open
@louisabraham

Description

@louisabraham

I implemented authentication on my app with this code:

@middleware
async def auth(request, handler):
    if request.headers.get("Authorization") == f"Bearer {TOKEN}":
        return await handler(request)
    return web.Response(status=401)

The problem is that OPTIONS requests don't contain authentication headers (https://stackoverflow.com/a/40723041/5133167), and the middleware doesn't return the CORS headers.

I could solve my issue by adding a condition:

@middleware
async def auth(request, handler):
    # skip auth for OPTIONS requests
    if (
        request.method == "OPTIONS"
        or request.headers.get("Authorization") == f"Bearer {TOKEN}"
    ):
        return await handler(request)
    return web.Response(status=401)

but I think it's ugly and that users shouldn't have to deal with this.

Is there a general way to enforce CORS on any middleware?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions