Unsafe Adhoc Cookies Passed To request()

[tylersalminen]

Is your feature request related to a problem?

No response

Describe the solution you'd like

Ability to pass unsafe cookies (host name is IP address) to request() method of ClientSession. This was possible in A prior version before they started getting filtered out in the internal _request() method

morsal = Morsel()
morsal.update(
	dict(
		key='key',
		value='********'
	)
)

client_session.request(
	"POST",
	"http://10.*.*.*:8000/api/v1/",
    cookies={
        "key": morsal
    },
	cookies_unsafe=True
)

The relevant lines that would need to be updated are in (refering to v. 3.13.3) client.py ClientSession._request() method lines 682 to 691.

all_cookies = self._cookie_jar.filter_cookies(url)

if cookies is not None:
	tmp_cookie_jar = CookieJar(
		quote_cookie=self._cookie_jar.quote_cookie
	)
	tmp_cookie_jar.update_cookies(cookies)
	req_cookies = tmp_cookie_jar.filter_cookies(url)
	if req_cookies:
		all_cookies.load(req_cookies)

update to

all_cookies = self._cookie_jar.filter_cookies(url)

if cookies is not None:
	tmp_cookie_jar = CookieJar(
		quote_cookie=self._cookie_jar.quote_cookie,
		unsafe=cookies_unsafe
	)
	tmp_cookie_jar.update_cookies(cookies)
	req_cookies = tmp_cookie_jar.filter_cookies(url)
	if req_cookies:
		all_cookies.load(req_cookies)

Describe alternatives you've considered

There are no viable alternatives as I cannot maintain a global cookie jar with unsafe set to true within the infrastructure I am working in.

Related component

Client

Additional context

No response

Code of Conduct

• I agree to follow the aio-libs Code of Conduct

[Dreamsorcerer]

We could just copy the setting from the session cookie jar. I asked about this in #10093 (comment)
But, looking back, that part of the question was never actually answered.

@bdraco Think we should copy the setting? Any reason we shouldn't?

[tylersalminen]

Personally I use a dummy cookie jar. So if it would be able to copy the setting from that I wouldn't care but I cannot remember if you can set such parameters to the dummy cookie jars. I aggressively reuse client sessions between many different users that's why I manually pass in cookies and don't use a cookie jar.

[Dreamsorcerer]

So if it would be able to copy the setting from that I wouldn't care but I cannot remember if you can set such parameters to the dummy cookie jars.

The attribute doesn't exist currently as there's no reason for it to. If we add this to the copying, then it will need to be added to the dummy cookie jar, just like quote_cookie was in the linked PR. I think it's fine to make the attributes configurable to support this case.