The flake8 setup had drifted from the plugins actually installed: tox's qa env and the GA lint job installed different plugin subsets, the select list overrode plugin defaults so several installed tools never ran anywhere, and configs existed for tools that were never dependencies (isort, flake8-logging-format) or never effective (mccabe without max-complexity). - requirements-dev.txt is now the single plugin list; the tox qa env consumes it via -r and the [flake8_plugins] pseudo-section is gone - select/ignore become extend-select/extend-ignore so installed plugins run with their default rule sets - newly enforced: bugbear (+B950), builtins, bandit, import-order, requirements; violations they surfaced are fixed (import order, long lines) or ignored with a stated reason (dev tooling subprocess use, test-data random) - the dangling enable-extensions=G is removed instead of adopting flake8-logging-format: the plugin still imports pkg_resources and cannot load under modern setuptools; the G003/G004 call sites it would have flagged are fixed here anyway (lazy % logging args) - stale ignores SIM106 and W293 removed; unused [tool.isort] block removed; missing colorama/packaging/docutils requirements declared - max-complexity=34 makes the long-selected C90 actually run, as a no-regression ratchet over the current worst offender (33) - the standalone bandit run is folded into flake8-bandit; bandit.yml retired with its B101/B404 skips carried over as S101/S404 - flake8-annotations/-coverage dropped from the aspirational list: they never ran in CI, the codebase has 1700+ violations, and mypy is the typing gate Fixes aio-libs#604 Fixes aio-libs#605 Fixes aio-libs#606 Fixes aio-libs#607 Fixes aio-libs#608 Fixes aio-libs#609 Fixes aio-libs#610 Fixes aio-libs#611 Fixes aio-libs#612

Uh oh!

Uh oh!

flake8-builtins is listed in requirements-dev.txt and tox.ini but not selected #608

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions