Skip to content

Conversation

devin-ai-integration[bot]
Copy link
Contributor

This PR targets the following PR:


This PR fixes asyncio event loop issues in the HTTP caching implementation:

  1. Modified the cache.py implementation to properly handle the event loop in the proxy thread
  2. Updated the example script to demonstrate proper usage of HTTP caching
  3. Fixed error handling to ensure the cache works reliably

The HTTP caching now works correctly with mitmproxy's native format for caching HTTP requests and responses.

Link to Devin run: https://app.devin.ai/sessions/2d488c91184d4d47b7b2916fc11e6162
Requested by: Aaron ("AJ") Steers ([email protected])

Copy link
Contributor Author

Original prompt from Aaron:

@Devin - I want you to create a new PR targeting the one below. But before you start, I want you to check out the branch and run the new script there that was created for testing. Tell me what you observe when running the script and then let's make a plan to resolve issues found. <https://github.com/airbytehq/PyAirbyte/pull/646|https://github.com/airbytehq/PyAirbyte/pull/646>

Copy link
Contributor Author

devin-ai-integration bot commented Apr 1, 2025

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@aaronsteers aaronsteers merged commit 82c4c83 into devin/1743363370-http-caching Apr 1, 2025
13 of 16 checks passed
@aaronsteers aaronsteers deleted the devin/fix-http-caching-asyncio branch April 1, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant