From c22c2a0271bec98fa2f01e6f0f47a509d5242077 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 4 Sep 2025 22:15:25 +0000 Subject: [PATCH 1/6] ci: Add GitHub action linting workflow Co-Authored-By: AJ Steers --- .github/workflows/actionlint.yml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 .github/workflows/actionlint.yml diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml new file mode 100644 index 00000000..9c649c71 --- /dev/null +++ b/.github/workflows/actionlint.yml @@ -0,0 +1,25 @@ +name: GitHub action linting + +on: + push: + branches: + - main + paths: + - '.github/workflows/**' + pull_request: + paths: + - '.github/workflows/**' + +jobs: + actionlint: + name: actionlint + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v4 + - name: Run actionlint + uses: reviewdog/action-actionlint@v1.67.0 + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + reporter: github-pr-review + level: error From 902723a4d26fa5f2720c79bbc9c245a13dd2ec8c Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Fri, 5 Sep 2025 00:10:08 +0000 Subject: [PATCH 2/6] test: Add invalid parameter to test actionlint error reporting Co-Authored-By: AJ Steers --- .github/workflows/actionlint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index 9c649c71..8cf392cd 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -23,3 +23,4 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-review level: error + invalid_parameter: this-does-not-exist From 98df7ca3e32dad45c1327a3eff2c52e154a34376 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Fri, 5 Sep 2025 00:12:07 +0000 Subject: [PATCH 3/6] fix: Add explicit permissions and create actionlint syntax error for testing - Add permissions block with contents:read and pull-requests:write - Replace invalid parameter with YAML syntax error to test reviewdog annotations - Addresses GitHub Advanced Security bot suggestion about missing permissions Co-Authored-By: AJ Steers --- .github/workflows/actionlint.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index 8cf392cd..64444302 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -10,6 +10,10 @@ on: paths: - '.github/workflows/**' +permissions: + contents: read + pull-requests: write + jobs: actionlint: name: actionlint @@ -23,4 +27,7 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-review level: error - invalid_parameter: this-does-not-exist + - name: Intentional syntax error for testing + run: | + echo "This step has invalid YAML syntax below" + invalid_yaml_key_without_proper_indentation: test From d0ea7f62a724af7b3954d1288c6c60a9c470cf52 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Fri, 5 Sep 2025 00:23:04 +0000 Subject: [PATCH 4/6] fix: Replace YAML syntax error with actionlint-detectable error - Fix YAML syntax to allow workflow parsing by GitHub Actions - Use nonexistent action reference that actionlint can detect and report - This should trigger proper reviewdog PR annotations for testing Co-Authored-By: AJ Steers --- .github/workflows/actionlint.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index 64444302..a0d80e24 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -27,7 +27,7 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-review level: error - - name: Intentional syntax error for testing - run: | - echo "This step has invalid YAML syntax below" - invalid_yaml_key_without_proper_indentation: test + - name: Test step with actionlint error + uses: nonexistent/invalid-action@v999 + with: + fake_parameter: test From de79df3340cf367db0a8e5c67121f4c962268882 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Fri, 5 Sep 2025 00:33:08 +0000 Subject: [PATCH 5/6] fix: Remove push triggers, run actionlint only on pull requests Co-Authored-By: AJ Steers --- .github/workflows/actionlint.yml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index a0d80e24..8d796ff8 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -1,11 +1,6 @@ name: GitHub action linting on: - push: - branches: - - main - paths: - - '.github/workflows/**' pull_request: paths: - '.github/workflows/**' @@ -27,7 +22,3 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-review level: error - - name: Test step with actionlint error - uses: nonexistent/invalid-action@v999 - with: - fake_parameter: test From 38e16182e7a53c5753d10d8f52f5fafa78e9424f Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Fri, 5 Sep 2025 00:35:57 +0000 Subject: [PATCH 6/6] fix: Add fail_on_error to block CI on actionlint failures Co-Authored-By: AJ Steers --- .github/workflows/actionlint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index 8d796ff8..0449fd19 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -22,3 +22,4 @@ jobs: github_token: ${{ secrets.GITHUB_TOKEN }} reporter: github-pr-review level: error + fail_on_error: true