Skip to content

Commit 3ae6bd7

Browse files
aaronsteersaaronsteers
authored
CI: update test workflows (#26)
1 parent a9cd5ca commit 3ae6bd7

File tree

4 files changed

+90
-82
lines changed

4 files changed

+90
-82
lines changed

‎.github/workflows/connector-tests.yml

+20-25
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,15 @@
1-
name: Connectors Tests
1+
name: Test Connectors
2+
on:
3+
workflow_dispatch:
4+
pull_request:
5+
types:
6+
- opened
7+
- synchronize
8+
# TODO: Consider moving to run these only after the "PyTest (Fast)" workflow is successful.
9+
# workflow_run:
10+
# workflows: [PyTest (Fast)]
11+
# types:
12+
# - completed
213

314
concurrency:
415
# This is the name of the concurrency group. It is used to prevent concurrent runs of the same workflow.
@@ -11,12 +22,6 @@ concurrency:
1122
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
1223
cancel-in-progress: true
1324

14-
on:
15-
workflow_dispatch:
16-
pull_request:
17-
types:
18-
- opened
19-
- synchronize
2025
jobs:
2126
cdk_changes:
2227
name: Get Changes
@@ -51,21 +56,6 @@ jobs:
5156
vector-db-based: ${{ steps.changes.outputs.vector-db-based }}
5257
sql: ${{ steps.changes.outputs.sql }}
5358

54-
# # The Connector CI Tests is a status check emitted by airbyte-ci
55-
# # We make it pass once we have determined that there are no changes to the connectors
56-
# - name: "Skip Connectors CI tests"
57-
# if: steps.changes.outputs.src != 'true' && github.event_name == 'pull_request'
58-
# run: |
59-
# curl --request POST \
60-
# --url https://api.github.com/repos/${{ github.repository }}/statuses/${{ github.event.pull_request.head.sha }} \
61-
# --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \
62-
# --header 'content-type: application/json' \
63-
# --data '{
64-
# "state": "success",
65-
# "context": "CDK Changes - Connectors Tests",
66-
# "target_url": "${{ github.event.workflow_run.html_url }}"
67-
# }' \
68-
6959
connectors_ci:
7060
needs: cdk_changes
7161
# We only run the Connectors CI job if there are changes to the connectors on a non-forked PR
@@ -89,9 +79,7 @@ jobs:
8979
cdk_extra: vector-db-based
9080
- connector: destination-motherduck
9181
cdk_extra: sql
92-
if: >
93-
( github.event_name == 'pull_request' && needs.cdk_changes.outputs.src == 'true' && github.event.pull_request.head.repo.fork != true
94-
) || github.event_name == 'workflow_dispatch'
82+
9583
name: "Check: '${{matrix.connector}}' (skip=${{needs.cdk_changes.outputs[matrix.cdk_extra] == 'false'}})"
9684
steps:
9785
- name: Abort if extra not changed (${{matrix.cdk_extra}})
@@ -103,18 +91,25 @@ jobs:
10391
exit 1
10492
continue-on-error: true
10593
# Get the monorepo so we can test the connectors
94+
- name: Checkout CDK
95+
if: steps.no_changes.outcome != 'failure'
96+
uses: actions/checkout@v4
97+
with:
98+
path: airbyte-python-cdk
10699
- name: Checkout Airbyte Monorepo
107100
uses: actions/checkout@v4
108101
if: steps.no_changes.outcome != 'failure'
109102
with:
110103
repository: airbytehq/airbyte
111104
ref: master
105+
path: airbyte
112106
- name: Test Connector
113107
if: steps.no_changes.outcome != 'failure'
114108
timeout-minutes: 90
115109
env:
116110
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
117111
run: |
112+
cd airbyte
118113
make tools.airbyte-ci-binary.install
119114
airbyte-ci connectors \
120115
--name ${{matrix.connector}} \

‎.github/workflows/pytest_fast.yml

+59
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
name: Pytest (Fast)
2+
3+
on:
4+
push:
5+
branches:
6+
- main
7+
paths:
8+
- 'airbyte_cdk/**'
9+
- 'poetry.lock'
10+
- 'pyproject.toml'
11+
pull_request:
12+
paths:
13+
- 'airbyte_cdk/**'
14+
- 'poetry.lock'
15+
- 'pyproject.toml'
16+
17+
jobs:
18+
pytest-fast:
19+
name: Pytest (Fast)
20+
runs-on: ubuntu-latest
21+
steps:
22+
# Common steps:
23+
- name: Checkout code
24+
uses: actions/checkout@v4
25+
- name: Set up Poetry
26+
uses: Gr1N/setup-poetry@v9
27+
with:
28+
poetry-version: "1.7.1"
29+
- name: Set up Python
30+
uses: actions/setup-python@v5
31+
with:
32+
python-version: "3.10"
33+
cache: "poetry"
34+
- name: Install dependencies
35+
run: poetry install --all-extras
36+
37+
- name: Run Pytest with Coverage (Fast Tests Only)
38+
timeout-minutes: 20
39+
run: >
40+
poetry run coverage run -m pytest
41+
--durations=5 --exitfirst
42+
-m "not slow"
43+
44+
- name: Print Coverage Report
45+
if: always()
46+
run: poetry run coverage report
47+
48+
- name: Create Coverage Artifacts
49+
if: always()
50+
run: |
51+
poetry run coverage html -d htmlcov
52+
poetry run coverage xml -o htmlcov/coverage.xml
53+
54+
- name: Upload coverage to GitHub Artifacts
55+
if: always()
56+
uses: actions/upload-artifact@v4
57+
with:
58+
name: fasttest-coverage
59+
path: htmlcov/

‎.github/workflows/python_pytest.yml ‎.github/workflows/pytest_matrix.yml

+10-57
Original file line numberDiff line numberDiff line change
@@ -5,70 +5,23 @@
55
# 2. `pytest`: Run all tests, across multiple Python versions.
66
#
77
# Note that `pytest-fast` also skips tests that require credentials, allowing it to run on forks.
8-
name: PyTest
8+
name: PyTest Matrix
99

1010
on:
1111
push:
1212
branches:
1313
- main
14-
pull_request: {}
14+
paths:
15+
- 'airbyte_cdk/**'
16+
- 'poetry.lock'
17+
- 'pyproject.toml'
18+
pull_request:
19+
paths:
20+
- 'airbyte_cdk/**'
21+
- 'poetry.lock'
22+
- 'pyproject.toml'
1523

1624
jobs:
17-
pytest-fast:
18-
name: Pytest (Fast)
19-
runs-on: ubuntu-latest
20-
steps:
21-
# Common steps:
22-
- name: Checkout code
23-
uses: actions/checkout@v4
24-
- name: Set up Poetry
25-
uses: Gr1N/setup-poetry@v9
26-
with:
27-
poetry-version: "1.7.1"
28-
- name: Set up Python
29-
uses: actions/setup-python@v5
30-
with:
31-
python-version: "3.10"
32-
cache: "poetry"
33-
- name: Install dependencies
34-
run: poetry install --all-extras
35-
36-
- name: Run Pytest with Coverage (Fast Tests Only)
37-
timeout-minutes: 60
38-
env:
39-
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
40-
run: >
41-
poetry run coverage run -m pytest
42-
--durations=5 --exitfirst
43-
-m "not slow and not requires_creds and not linting and not flaky"
44-
45-
- name: Run Pytest with Coverage (Flaky Tests Only)
46-
timeout-minutes: 60
47-
continue-on-error: true
48-
env:
49-
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
50-
run: >
51-
poetry run coverage run -m pytest
52-
--durations=5 --exitfirst
53-
-m "flaky and not slow and not requires_creds"
54-
55-
- name: Print Coverage Report
56-
if: always()
57-
run: poetry run coverage report
58-
59-
- name: Create Coverage Artifacts
60-
if: always()
61-
run: |
62-
poetry run coverage html -d htmlcov
63-
poetry run coverage xml -o htmlcov/coverage.xml
64-
65-
- name: Upload coverage to GitHub Artifacts
66-
if: always()
67-
uses: actions/upload-artifact@v4
68-
with:
69-
name: fasttest-coverage
70-
path: htmlcov/
71-
7225
pytest:
7326
name: Pytest (All, Python ${{ matrix.python-version }}, ${{ matrix.os }})
7427
# Don't run on forks. Run on pushes to main, and on PRs that are not from forks.

‎pyproject.toml

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
requires = ["poetry-core>=1.0.0", "poetry-dynamic-versioning>=1.0.0,<2.0.0"]
33
build-backend = "poetry_dynamic_versioning.backend"
44

5+
56
[tool.poetry]
67
name = "airbyte-cdk"
78
description = "A framework for writing Airbyte Connectors."

0 commit comments

Comments
 (0)