Skip to content

Commit f13b128

Browse files
committed
Add dynamic_streams_name only for full_resolve command
1 parent 97f4614 commit f13b128

File tree

5 files changed

+6
-398
lines changed

5 files changed

+6
-398
lines changed

airbyte_cdk/sources/declarative/declarative_component_schema.yaml

-7
Original file line numberDiff line numberDiff line change
@@ -1427,13 +1427,6 @@ definitions:
14271427
- "$ref": "#/definitions/LegacyToPerPartitionStateMigration"
14281428
- "$ref": "#/definitions/CustomStateMigration"
14291429
default: []
1430-
dynamic_stream_name:
1431-
title: Dynamic Stream Name
1432-
description: The dynamic stream name that create current stream, if None is static stream.
1433-
type: string
1434-
default: None
1435-
example:
1436-
- "Tables"
14371430
$parameters:
14381431
type: object
14391432
additional_properties: true

airbyte_cdk/sources/declarative/manifest_declarative_source.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def message_repository(self) -> MessageRepository:
119119

120120
@property
121121
def dynamic_streams(self) -> List[Dict[str, Any]]:
122-
return self._dynamic_stream_configs(manifest=self._source_config, config=self._config)
122+
return self._dynamic_stream_configs(manifest=self._source_config, config=self._config, with_dynamic_stream_name=True)
123123

124124
@property
125125
def connection_checker(self) -> ConnectionChecker:
@@ -353,7 +353,7 @@ def _stream_configs(self, manifest: Mapping[str, Any]) -> List[Dict[str, Any]]:
353353
return stream_configs
354354

355355
def _dynamic_stream_configs(
356-
self, manifest: Mapping[str, Any], config: Mapping[str, Any]
356+
self, manifest: Mapping[str, Any], config: Mapping[str, Any], with_dynamic_stream_name: Optional[bool] = None
357357
) -> List[Dict[str, Any]]:
358358
dynamic_stream_definitions: List[Dict[str, Any]] = manifest.get("dynamic_streams", [])
359359
dynamic_stream_configs: List[Dict[str, Any]] = []
@@ -398,9 +398,10 @@ def _dynamic_stream_configs(
398398
# Ensure that each stream is created with a unique name
399399
name = dynamic_stream.get("name")
400400

401-
dynamic_stream["dynamic_stream_name"] = dynamic_definition.get(
402-
"name", f"dynamic_stream_{dynamic_definition_index}"
403-
)
401+
if with_dynamic_stream_name:
402+
dynamic_stream["dynamic_stream_name"] = dynamic_definition.get(
403+
"name", f"dynamic_stream_{dynamic_definition_index}"
404+
)
404405

405406
if not isinstance(name, str):
406407
raise ValueError(

airbyte_cdk/sources/declarative/models/declarative_component_schema.py

-6
Original file line numberDiff line numberDiff line change
@@ -2049,12 +2049,6 @@ class Config:
20492049
description="Array of state migrations to be applied on the input state",
20502050
title="State Migrations",
20512051
)
2052-
dynamic_stream_name: Optional[str] = Field(
2053-
"None",
2054-
description="The dynamic stream name that create current stream, if None is static stream.",
2055-
example=["Tables"],
2056-
title="Dynamic Stream Name",
2057-
)
20582052
parameters: Optional[Dict[str, Any]] = Field(None, alias="$parameters")
20592053

20602054

0 commit comments

Comments
 (0)