Skip to content

Conversation

aaronsteers
Copy link
Contributor

No description provided.

@Copilot Copilot AI review requested due to automatic review settings August 1, 2025 22:06
Copy link

github-actions bot commented Aug 1, 2025

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This Branch via MCP

To test the changes in this specific branch with an MCP client like Claude Desktop, use the following configuration:

{
  "mcpServers": {
    "builder-mcp-dev": {
      "command": "uvx",
      "args": ["--from", "git+https://github.com/airbytehq/builder-mcp.git@aj/fix/need-dummy-catalog", "builder-mcp"]
    }
  }
}

Testing This Branch via CLI

You can test this version of the MCP Server using the following CLI snippet:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/builder-mcp.git@aj/fix/need-dummy-catalog#egg=airbyte-builder-mcp' --help

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poe <command> - Runs any poe command in the uv virtual environment

📝 Edit this welcome message.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR resolves a catalog issue that was blocking test reads by renaming the execute_stream_read function to execute_stream_test_read and implementing a proper dummy catalog creation mechanism. The function now creates a configured catalog with the specified stream before attempting to read from it, which was previously missing and causing test failures.

Key changes:

  • Renamed execute_stream_read to execute_stream_test_read for clarity
  • Added _get_dummy_catalog helper function to create proper catalog structure
  • Updated catalog creation in the stream read operation to use the new helper

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
builder_mcp/_connector_builder.py Implements the main fix with function rename, catalog creation helper, and updated stream read logic
tests/test_integration.py Updates test function calls to use the renamed function
tests/init.py Updates import and function calls to use the renamed function
TESTING.md Updates documentation example to use the renamed function
Comments suppressed due to low confidence (1)

Copy link

github-actions bot commented Aug 1, 2025

PyTest Results (Full)

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit b3f10bb. ± Comparison against base commit cb55b1d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 1, 2025

PyTest Results (Fast)

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit b3f10bb. ± Comparison against base commit cb55b1d.

♻️ This comment has been updated with latest results.

@aaronsteers
Copy link
Contributor Author

aaronsteers commented Aug 1, 2025

/autofix

Auto-Fix Job Info

This job attempts to auto-fix any linting or formating issues. If any fixes are made,
those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

PR auto-fix job started... Check job output.

✅ Changes applied successfully.

@aaronsteers aaronsteers merged commit 70e6722 into main Aug 1, 2025
12 of 13 checks passed
@aaronsteers aaronsteers deleted the aj/fix/need-dummy-catalog branch August 1, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant