-
Notifications
You must be signed in to change notification settings - Fork 2
fix: resolve catalog issue that was blocking test read #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This Branch via MCPTo test the changes in this specific branch with an MCP client like Claude Desktop, use the following configuration: {
"mcpServers": {
"builder-mcp-dev": {
"command": "uvx",
"args": ["--from", "git+https://github.com/airbytehq/builder-mcp.git@aj/fix/need-dummy-catalog", "builder-mcp"]
}
}
} Testing This Branch via CLIYou can test this version of the MCP Server using the following CLI snippet: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/builder-mcp.git@aj/fix/need-dummy-catalog#egg=airbyte-builder-mcp' --help PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR resolves a catalog issue that was blocking test reads by renaming the execute_stream_read
function to execute_stream_test_read
and implementing a proper dummy catalog creation mechanism. The function now creates a configured catalog with the specified stream before attempting to read from it, which was previously missing and causing test failures.
Key changes:
- Renamed
execute_stream_read
toexecute_stream_test_read
for clarity - Added
_get_dummy_catalog
helper function to create proper catalog structure - Updated catalog creation in the stream read operation to use the new helper
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
builder_mcp/_connector_builder.py | Implements the main fix with function rename, catalog creation helper, and updated stream read logic |
tests/test_integration.py | Updates test function calls to use the renamed function |
tests/init.py | Updates import and function calls to use the renamed function |
TESTING.md | Updates documentation example to use the renamed function |
Comments suppressed due to low confidence (1)
Co-authored-by: Copilot <[email protected]>
…ehq/builder-mcp into aj/fix/need-dummy-catalog
/autofix
|
No description provided.