Skip to content

Commit 820abba

Browse files
style: improve deptry ignore comments to justify why ignoring is safe
Co-Authored-By: AJ Steers <aj@airbyte.io>
1 parent ee97bb7 commit 820abba

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

pyproject.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,15 +103,15 @@ ignore = []
103103
DEP001 = []
104104
# DEP002: unused dependency
105105
DEP002 = [
106-
"cyclopts", # optional [cli] extra; deptry can't see imports gated behind the extra
107-
"rich", # optional [cli] extra; deptry can't see imports gated behind the extra
106+
"cyclopts", # imported in cli.py; false positive because [cli] extra gating hides it from deptry
107+
"rich", # imported in cli.py; false positive because [cli] extra gating hides it from deptry
108108
]
109109
# DEP003: transitive dependency
110110
DEP003 = []
111111
# DEP004: misplaced dev dependency
112112
DEP004 = [
113-
"pytest", # dev dep imported only in tests/; deptry doesn't exclude test dirs from DEP004
114-
"uvicorn", # dev dep imported only in test fixtures for HTTP server testing
113+
"pytest", # only imported in tests/, never shipped; deptry can't scope DEP004 by directory
114+
"uvicorn", # only imported in test fixtures, never shipped; deptry can't scope DEP004 by directory
115115
]
116116

117117
[dependency-groups]

0 commit comments

Comments
 (0)