Skip to content

Commit 2114aca

Browse files
committed
fix: change streams to be a SetNestedAttribute
This commit modifies the connection resource's `streams` attribute to be a `SetNestedAttribute` instead of a List. This is so that we can properly compute plan's that treat re-ordering of elements (streams) as a noop (if no attributes of the stream have been changed). Previously if you added a new stream to a connection resource in the middle of the list, or changed the order, the provider would compute that as a change that had to be applied. Additionally, we use a customer SetPlanModifier that may be parameterized with a `key` which is used to uniquely identify the elements in the set. NOTE: the current implementation of the plan modifier `uniqueByKey` assumes that the elements of the set are Objects. Since this is the only use case for this modifier, this seems reasonable for now.
1 parent 4834a12 commit 2114aca

File tree

5 files changed

+1253
-1116
lines changed

5 files changed

+1253
-1116
lines changed

.genignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
internal/provider/connection_resource.go
2+
internal/provider/connection_data_resource.go

0 commit comments

Comments
 (0)