Fix CI: SC2034 false positives + stub host commands in status test

common.sh: SERVER_URL, MAX_RETRY_TIME, DRY_RUN, FORCE are written here and read by sibling modules sourced from the dispatcher. Standalone shellcheck doesn't follow the source graph so the per-file analysis flags them as unused. Per-line disables document the cross-module read.

test_apl_feed_cli.bats: the status test asserted Result text that depends on whether the host runner has systemctl, an active feed service, and an established socket on port 31090. Stub systemctl, nc, and ss in setup so checks resolve to ok regardless of host. Updated assertion to match the now-deterministic 'feeding looks healthy' result.

Author: d4rken

scripts/apl-feed/common.sh

@@ -1,9 +1,13 @@
 #!/usr/bin/env bash
 
 ROOT='/'
+# shellcheck disable=SC2034  # SERVER_URL/MAX_RETRY_TIME/DRY_RUN/FORCE are read by sibling modules sourced from apl-feed.sh
 SERVER_URL="${APL_FEED_SERVER_URL:-https://airplanes.live}"
+# shellcheck disable=SC2034
 MAX_RETRY_TIME="${APL_FEED_MAX_RETRY_TIME:-60}"
+# shellcheck disable=SC2034
 DRY_RUN=0
+# shellcheck disable=SC2034
 FORCE=0
 TMP_FILES=()
 
@@ -197,11 +201,13 @@ parse_common_option() {
             ;;
         --server-url)
             [[ $# -ge 2 ]] || die "--server-url requires URL"
+            # shellcheck disable=SC2034  # consumed by http.sh/claim.sh after parse
             SERVER_URL="$2"
             return 2
             ;;
         --max-retry-time)
             [[ $# -ge 2 ]] || die "--max-retry-time requires N"
+            # shellcheck disable=SC2034  # consumed by claim.sh after parse
             MAX_RETRY_TIME="$2"
             return 2
             ;;

test/test_apl_feed_cli.bats

@@ -8,11 +8,37 @@ setup() {
     echo "11111111-2222-3333-4444-555555555555" > "$ROOT_DIR/usr/local/share/airplanes/airplanes-uuid"
     MOCK_PORT_FILE="$(mktemp)"
     MOCK_PID_FILE="$(mktemp)"
+
+    # Stub external commands `apl-feed status` calls so the result-text
+    # assertions don't depend on whether the host runner has systemctl,
+    # active services, or established sockets. Defaults: services active,
+    # receiver port reachable, ingest link established.
+    STUB_BIN_DIR="$(mktemp -d)"
+    cat > "$STUB_BIN_DIR/systemctl" <<'STUB'
+#!/usr/bin/env bash
+case "$*" in
+    "is-active --quiet "*) exit 0 ;;
+    "is-enabled "*) echo "enabled"; exit 0 ;;
+esac
+exit 0
+STUB
+    cat > "$STUB_BIN_DIR/nc" <<'STUB'
+#!/usr/bin/env bash
+exit 0
+STUB
+    cat > "$STUB_BIN_DIR/ss" <<'STUB'
+#!/usr/bin/env bash
+printf 'ESTAB 0 0 127.0.0.1:43530 78.46.234.18:31090 \n'
+exit 0
+STUB
+    chmod +x "$STUB_BIN_DIR/systemctl" "$STUB_BIN_DIR/nc" "$STUB_BIN_DIR/ss"
+    PATH="$STUB_BIN_DIR:$PATH"
+    export PATH STUB_BIN_DIR
 }
 
 teardown() {
     stop_mock_server || true
-    rm -rf "$ROOT_DIR"
+    rm -rf "$ROOT_DIR" "$STUB_BIN_DIR"
     rm -f "$MOCK_PORT_FILE" "$MOCK_PID_FILE"
 }
 
@@ -173,7 +199,7 @@ PY
     [[ "$output" =~ "registered and claimed (v3)" ]]
     [[ "$output" =~ "Website feed" ]]
     [[ "$output" =~ "last data seen 1m ago" ]]
-    [[ "$output" =~ "Result: some checks need attention" ]]
+    [[ "$output" =~ "Result: feeding looks healthy" ]]
     [ "$(cat "$ROOT_DIR/etc/airplanes/claim-secret.version")" = "3" ]
 }