Drop legacy second-mlat.sh helper script

Inherited from wiedehopf/adsb-scripts in 2021. The script generated an airplanes-mlat2 systemd unit running a second mlat-client, but nothing invoked it from install/update/configure, the hostname was hardcoded so it was only useful after manual editing, and it was never documented or tested. update.sh now sweeps the stale copy off upgraded installs; uninstall.sh still cleans up airplanes-mlat2 for operators who manually ran the helper.

Author: d4rken

scripts/second-mlat.sh

@@ -84,6 +84,12 @@ chmod +x "$ROOT_DIR/usr/bin/airplanes-feeder"
 IPATH="$ROOT_DIR/usr/local/share/airplanes"
 mkdir -p "$IPATH/venv/bin"
 cp "$FEED_REPO/update.sh" "$IPATH/update.sh"
+# Simulate an upgraded install that still has the legacy second-mlat.sh
+# helper left over from an older feed release; update.sh must sweep it
+# regardless of whether the new tree carries the file or not. The post-update
+# `test ! -e "$IPATH/second-mlat.sh"` below guards the sweep.
+printf '#!/bin/bash\nexit 0\n' > "$IPATH/second-mlat.sh"
+chmod +x "$IPATH/second-mlat.sh"
 cat > "$IPATH/venv/bin/mlat-client" <<'SH'
 #!/usr/bin/env bash
 exit 0
@@ -177,6 +183,7 @@ test -x "$ROOT_DIR/usr/local/bin/apl-feed"
 test -f "$IPATH/apl-feed/common.sh"
 test -f "$IPATH/airplanes-feed.sh"
 test -f "$IPATH/airplanes-mlat.sh"
+test ! -e "$IPATH/second-mlat.sh"
 test -f "$ROOT_DIR/etc/systemd/system/airplanes-feed.service"
 test -f "$ROOT_DIR/etc/systemd/system/airplanes-mlat.service"
 test ! -e "$ROOT_DIR/lib/systemd/system/airplanes-feed.service"

test/image-rootfs-smoke.sh

@@ -347,6 +347,11 @@ fi
 
 cp "$GIT/uninstall.sh" "$IPATH"
 cp "$GIT"/scripts/*.sh "$IPATH"
+# Sweep the now-removed second-mlat.sh helper from upgraded installs. The
+# wildcard cp above only adds files that exist in scripts/; it does not
+# clean up files that used to ship there. See the airplanes-mlat2 cleanup
+# in uninstall.sh for the matching service-side handling.
+rm -f "$IPATH/second-mlat.sh"
 install -d -m 0755 "$IPATH/apl-feed"
 install -m 0644 "$GIT"/scripts/apl-feed/*.sh "$IPATH/apl-feed"
 mkdir -p "$LOCAL_BIN"
@@ -356,8 +361,8 @@ install -m 0755 "$GIT/scripts/apl-feed.sh" "$LOCAL_BIN/apl-feed"
 # users typically pick as their console/SSH login on a fresh image flash.
 # Existing installs keep their orphan "airplanes" user in /etc/passwd;
 # deleting it would risk breaking unknown local references (custom drop-ins,
-# an airplanes-mlat2.service generated by an older second-mlat.sh that still
-# pins User=airplanes, etc.).
+# an airplanes-mlat2.service generated by the now-removed legacy
+# second-mlat.sh that still pins User=airplanes, etc.).
 #
 # A private airplanes-feed group is created so other service accounts can
 # read claim-state files (mode 0640) without escalating to root. Membership