Skip to content

Commit a44e941

Browse files
authored
fix(inkless:ci): fail-fast all test suites (#220)
Currently the initial inkless test mistakingly continues but the result is not stopping the pipeline. This happened here: https://github.com/aiven/inkless/actions/runs/13853199477/job/38764586313?pr=218 Instead, this PR is removing the `--continue` and failing fast as the inkless tests are easier to retry than Kafka.
1 parent 99325d8 commit a44e941

File tree

2 files changed

+23
-19
lines changed

2 files changed

+23
-19
lines changed

.github/workflows/inkless-nightly.yml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -45,21 +45,23 @@ jobs:
4545
id: junit-test
4646
env:
4747
TIMEOUT_MINUTES: 30
48+
GRADLE_ARGS: >-
49+
--build-cache --no-scan
50+
-PtestLoggingEvents=started,passed,skipped,failed
51+
-PmaxParallelForks=2
52+
-PmaxTestRetries=1 -PmaxTestRetryFailures=3
53+
-PmaxQuarantineTestRetries=3 -PmaxQuarantineTestRetryFailures=0
54+
-PcommitId=xxxxxxxxxxxxxxxx
4855
# Point to inkless tests
4956
run: |
5057
set +e
5158
./.github/scripts/thread-dump.sh &
5259
# inkless tests
53-
timeout ${TIMEOUT_MINUTES}m ./gradlew --build-cache --continue --no-scan \
54-
-PtestLoggingEvents=started,passed,skipped,failed \
55-
-PmaxParallelForks=2 \
56-
-PmaxTestRetries=1 -PmaxTestRetryFailures=3 \
57-
-PmaxQuarantineTestRetries=3 -PmaxQuarantineTestRetryFailures=0 \
58-
-PcommitId=xxxxxxxxxxxxxxxx \
59-
:storage:inkless:test :storage:inkless:integrationTest && \
60-
./gradlew :metadata:test --tests "org.apache.kafka.controller.*" && \
61-
./gradlew :core:test --tests "*Inkless*" && \
62-
./gradlew :core:test --tests "kafka.api.*Producer*Test"
60+
timeout ${TIMEOUT_MINUTES}m \
61+
./gradlew ${GRADLE_ARGS} :storage:inkless:test :storage:inkless:integrationTest && \
62+
./gradlew ${GRADLE_ARGS} :metadata:test --tests "org.apache.kafka.controller.*" && \
63+
./gradlew ${GRADLE_ARGS} :core:test --tests "*Inkless*" && \
64+
./gradlew ${GRADLE_ARGS} :core:test --tests "kafka.api.*Producer*Test"
6365
exitcode="$?"
6466
echo "exitcode=$exitcode" >> $GITHUB_OUTPUT
6567
- name: Archive JUnit HTML reports

.github/workflows/inkless.yml

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -106,20 +106,22 @@ jobs:
106106
id: junit-test
107107
env:
108108
TIMEOUT_MINUTES: 30
109+
GRADLE_ARGS: >-
110+
--build-cache --no-scan
111+
-PtestLoggingEvents=started,passed,skipped,failed
112+
-PmaxParallelForks=2
113+
-PmaxTestRetries=1 -PmaxTestRetryFailures=3
114+
-PmaxQuarantineTestRetries=3 -PmaxQuarantineTestRetryFailures=0
115+
-PcommitId=xxxxxxxxxxxxxxxx
109116
# Point to inkless tests
110117
run: |
111118
set +e
112119
./.github/scripts/thread-dump.sh &
113120
# inkless tests
114-
timeout ${TIMEOUT_MINUTES}m ./gradlew --build-cache --continue --no-scan \
115-
-PtestLoggingEvents=started,passed,skipped,failed \
116-
-PmaxParallelForks=2 \
117-
-PmaxTestRetries=1 -PmaxTestRetryFailures=3 \
118-
-PmaxQuarantineTestRetries=3 -PmaxQuarantineTestRetryFailures=0 \
119-
-PcommitId=xxxxxxxxxxxxxxxx \
120-
:storage:inkless:test :storage:inkless:integrationTest && \
121-
./gradlew :metadata:test --tests "org.apache.kafka.controller.*" && \
122-
./gradlew :core:test --tests "*Inkless*"
121+
timeout ${TIMEOUT_MINUTES}m \
122+
./gradlew ${GRADLE_ARGS} :storage:inkless:test :storage:inkless:integrationTest && \
123+
./gradlew ${GRADLE_ARGS} :metadata:test --tests "org.apache.kafka.controller.*" && \
124+
./gradlew ${GRADLE_ARGS} :core:test --tests "*Inkless*"
123125
exitcode="$?"
124126
echo "exitcode=$exitcode" >> $GITHUB_OUTPUT
125127
- name: Archive JUnit HTML reports

0 commit comments

Comments
 (0)