fix(zsh): detect relative paths through symlinks as directories#1256
Closed
salarkhannn wants to merge 1 commit into
Closed
fix(zsh): detect relative paths through symlinks as directories#1256salarkhannn wants to merge 1 commit into
salarkhannn wants to merge 1 commit into
Conversation
When cwd is a symlink, [[ -d ../foo ]] follows the symlink before resolving .., so the check fails even though cd ../foo would succeed via the shell's logical path tracking. Allow paths containing .. through to __zoxide_cd, which relies on the shell's native cd behavior. Fixes ajeetdsouza#1166
Owner
|
Thanks for the PR. However, this would break queries that used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the current directory is a symlink,
[[ -d ../foo ]]resolves the symlink before expanding.., so the directory check fails even thoughcd ../foowould succeed using the shell's logical path tracking.Fix: also match paths containing
..so they fall through to__zoxide_cd, which relies on the shell's nativecdbehavior.Closes #1166