Merge pull request #50 from akanoce/fix-eslint-config

chore: bump root packages, fix eslint config and dependency cycle

Author: akanoce

apps/next-app/.eslintrc.cjs

@@ -7,8 +7,10 @@ module.exports = {
   parserOptions: {
     ecmaVersion: 2020,
     sourceType: "module",
+    project: "./tsconfig.json",
+    tsconfigRootDir: __dirname,
   },
-  plugins: ["prettier"],
+  plugins: ["react-refresh", "prettier", "@typescript-eslint"],
   rules: {
     "prettier/prettier": [
       "error",
@@ -21,5 +23,7 @@ module.exports = {
     "react/require-default-props": "off",
     "react/function-component-definition": "off",
     "react/react-in-jsx-scope": "off",
+    "@typescript-eslint/lines-between-class-members": "off",
+    "@typescript-eslint/no-throw-literal": "off",
   },
 };

apps/next-app/package.json

@@ -11,14 +11,14 @@
     "clean": "rm -rf .next"
   },
   "dependencies": {
-    "aave-v3-react": "*",
     "@chakra-ui/next-js": "^2.2.0",
     "@chakra-ui/react": "^2.8.2",
     "@emotion/react": "^11.11.4",
     "@emotion/styled": "^11.11.5",
     "@repo/components": "*",
     "@tanstack/react-query": "^5.28.14",
     "@tanstack/react-query-devtools": "^5.28.14",
+    "aave-v3-react": "*",
     "connectkit": "^1.7.3",
     "encoding": "^0.1.13",
     "ethers": "5",
@@ -37,7 +37,9 @@
     "@types/node": "^20",
     "@types/react": "^18",
     "@types/react-dom": "^18",
-    "eslint": "^8",
+    "@typescript-eslint/eslint-plugin": "^8.28.0",
+    "@typescript-eslint/parser": "^8.28.0",
+    "eslint": "^8.57.0",
     "eslint-config-airbnb": "^19.0.4",
     "eslint-config-airbnb-typescript": "^18.0.0",
     "eslint-config-next": "14.2.3",

apps/vite-app/.eslintrc.cjs

@@ -12,10 +12,10 @@ module.exports = {
   ignorePatterns: ["dist", ".eslintrc.cjs"],
   parser: "@typescript-eslint/parser",
   parserOptions: {
-    
-   project: "./tsconfig.json"
+    project: "./tsconfig.json",
+    tsconfigRootDir: __dirname,
   },
-  plugins: ["react-refresh", "prettier"],
+  plugins: ["react-refresh", "prettier", "@typescript-eslint"],
   rules: {
     "react-refresh/only-export-components": [
       "warn",
@@ -35,6 +35,7 @@ module.exports = {
     "import/extensions": "off",
     "import/export": "off",
     "import/no-extraneous-dependencies": "off",
-
+    "@typescript-eslint/lines-between-class-members": "off",
+    "@typescript-eslint/no-throw-literal": "off",
   },
 };

apps/vite-app/package.json

@@ -32,8 +32,8 @@
   "devDependencies": {
     "@types/react": "^18.3.3",
     "@types/react-dom": "^18.3.0",
-    "@typescript-eslint/eslint-plugin": "^7.8.0",
-    "@typescript-eslint/parser": "^7.8.0",
+    "@typescript-eslint/eslint-plugin": "^8.28.0",
+    "@typescript-eslint/parser": "^8.28.0",
     "@vitejs/plugin-react": "^4.2.1",
     "eslint": "^8.57.0",
     "eslint-config-airbnb": "^19.0.4",

package.json

@@ -18,20 +18,20 @@
   "engines": {
     "node": ">=18"
   },
-  "packageManager": "[email protected].19",
+  "packageManager": "[email protected].22",
   "workspaces": [
     "apps/*",
     "packages/*"
   ],
   "devDependencies": {
-    "@commitlint/cli": "^19.3.0",
-    "@commitlint/config-conventional": "^19.2.2",
-    "husky": "^9.0.11",
-    "prettier": "^3.3.1",
-    "semantic-release": "^24.0.0"
+    "@commitlint/cli": "^19.8.0",
+    "@commitlint/config-conventional": "^19.8.0",
+    "husky": "^9.1.7",
+    "prettier": "^3.5.3",
+    "semantic-release": "^24.2.3"
   },
   "dependencies": {
-    "@changesets/cli": "^2.27.5",
-    "turbo": "^2.0.3"
+    "@changesets/cli": "^2.28.1",
+    "turbo": "^2.4.4"
   }
 }

packages/aave-v3-react/.eslintrc.cjs

@@ -13,8 +13,9 @@ module.exports = {
   parser: "@typescript-eslint/parser",
   parserOptions: {
     project: "./tsconfig.json",
+    tsconfigRootDir: __dirname,
   },
-  plugins: ["react-refresh", "prettier"],
+  plugins: ["react-refresh", "prettier", "@typescript-eslint"],
   rules: {
     "react-refresh/only-export-components": [
       "warn",
@@ -34,5 +35,7 @@ module.exports = {
     "consistent-return": "off",
     "@typescript-eslint/no-unused-vars": "off",
     "import/extensions": "off",
+    "@typescript-eslint/lines-between-class-members": "off",
+    "@typescript-eslint/no-throw-literal": "off",
   },
 };

packages/aave-v3-react/package.json

@@ -41,6 +41,8 @@
   "devDependencies": {
     "@types/react": "^18.2.74",
     "@types/react-dom": "^18.2.24",
+    "@typescript-eslint/eslint-plugin": "^8.28.0",
+    "@typescript-eslint/parser": "^8.28.0",
     "eslint-config-airbnb": "^19.0.4",
     "eslint-config-airbnb-typescript": "^18.0.0",
     "eslint-config-prettier": "^9.1.0",

packages/aave-v3-react/src/hooks/useEthersProvider/useEthersProvider.ts

@@ -13,8 +13,8 @@ export function clientToProvider(client: Client<Transport, Chain>) {
   if (transport.type === "fallback")
     return new providers.FallbackProvider(
       (transport.transports as ReturnType<Transport>[]).map(
-        ({ value }) => new providers.JsonRpcProvider(value?.url, network)
-      )
+        ({ value }) => new providers.JsonRpcProvider(value?.url, network),
+      ),
     );
   return new providers.JsonRpcProvider(transport.url, network);
 }

packages/aave-v3-react/src/providers/AaveContractsProvider.tsx

@@ -7,9 +7,9 @@ import {
 import { createContext, useContext, useMemo } from "react";
 import { providers } from "ethers";
 
-import { SupportedAddressBook, getAddressBookFromChainid } from "../utils";
 import { useChainId } from "wagmi";
-import { useEthersProvider } from "..";
+import { SupportedAddressBook, getAddressBookFromChainid } from "../utils";
+import { useEthersProvider } from "../hooks/useEthersProvider/useEthersProvider";
 
 /**
  * Context to provide Aave V3 contracts to the app
@@ -41,9 +41,7 @@ type Props = {
  * @param children - The children of the provider
  * @returns The Aave V3 contracts provider
  */
-export const AaveContractsProvider = ({
-  children,
-}: Props) => {
+export const AaveContractsProvider = ({ children }: Props) => {
   const chainId = useChainId();
   const provider = useEthersProvider({ chainId });
 
@@ -52,8 +50,6 @@ export const AaveContractsProvider = ({
     [chainId],
   );
 
-  
-
   // View contract used to fetch all reserves data (including market base currency data), and user reserves
   // Using Aave V3 Eth Mainnet address for demo
   const poolDataProviderContract = useMemo(

packages/components/.eslintrc.cjs

@@ -14,8 +14,10 @@ module.exports = {
   parserOptions: {
     ecmaVersion: 2020,
     sourceType: "module",
+    project: "./tsconfig.json",
+    tsconfigRootDir: __dirname,
   },
-  plugins: ["react-refresh", "prettier"],
+  plugins: ["react-refresh", "prettier", "@typescript-eslint"],
   rules: {
     "react-refresh/only-export-components": [
       "warn",
@@ -34,5 +36,7 @@ module.exports = {
     "react/react-in-jsx-scope": "off",
     "react/prop-types": "off",
     "@typescript-eslint/ban-ts-comment": "off",
+    "@typescript-eslint/lines-between-class-members": "off",
+    "@typescript-eslint/no-throw-literal": "off",
   },
 };